nastra commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1530141957
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -136,6 +138,18 @@ public static void dropTableData(FileIO io, TableMetadata
metadata) {
deleteFile(io, metadata.metadataFileLocation(), "metadata");
}
+ /**
+ * Drops view metadata files referenced by ViewMetadata.
+ *
+ * <p>This should be called by dropView implementations
+ *
+ * @param io a FileIO to use for deletes
+ * @param metadata the last valid ViewMetadata instance for a dropped view.
+ */
+ public static void dropViewMetadata(FileIO io, ViewMetadata metadata) {
Review Comment:
from what I understand, this PR only refactors a bunch of things to make it
easier to add view support. That means we probably shouldn't be adding
view-specific things in this PR as we just want to move stuff around and
provide the exact same code behavior that previously existed, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
