nastra commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535407624
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -62,6 +82,48 @@ interface HiveOperationsBase {
String table();
+ String catalogName();
+
+ ContentType contentType();
+
+ default Table loadHmsTable() throws TException, InterruptedException {
+ try {
+ return metaClients().run(client -> client.getTable(database(), table()));
+ } catch (NoSuchObjectException nte) {
+ LOG.trace(
+ "{} not found {}", contentType(), catalogName() + "." + database() +
"." + table(), nte);
Review Comment:
```suggestion
"{} not found {}", contentType(), database() + "." + table(), nte);
```
this is just TRACE logging, so it should be ok to not have the catalog. I'm
not even sure that logging stmt should even exist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
