Simone Tiraboschi has posted comments on this change.
Change subject: core: transaction: destructor should be at unmanaged object
..
Patch Set 1: Code-Review+1
Ok, I'm trying to verify it with my code
--
To view, visit https:
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42032
To unsubscribe, visit https://gerri
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 18:
(3 comments)
https://gerrit.ovirt.org/#/c/42032/18/packaging/setup/plugins/ovirt-engine-reports-to
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: improoving cloud-init config UX
..
Patch Set 6: Verified+1
Verified on manual and on automated setup
--
To view, visit https://gerrit.ovi
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: Stop services only when needed
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42430
To unsubscribe, visit https:
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: Stop services only when needed
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42411
To unsubscribe, visit https:
Simone Tiraboschi has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
> there is no sense in filtering boolean values.
Why?
> also, your patch is fundamentally wr
Simone Tiraboschi has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
> what you are doing is bad programming practice.
>
> environment keys should be simple and
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: improoving cloud-init config UX
..
Patch Set 1: Verified+1
Now it looks more consistent:
--== VM CONFIGURATION ==--
Simone Tiraboschi has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
> and? what is the problem?
After that otopi stops logging cause is filtering every single li
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: improoving cloud-init config UX
..
packaging: setup: improoving cloud-init config UX
- asking about appliance location just after disk/cdr
Simone Tiraboschi has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
> What is the exact issue, please send me a log to show that.
The issue is here (on the last
Simone Tiraboschi has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2:
> I am unsure I understand when we have boolean keys in environment.
OVEHOSTED_VM/cloudinitRo
Simone Tiraboschi has posted comments on this change.
Change subject: log: preventing boolean values to stop logging
..
Patch Set 2: Verified+1
Verified using OVEHOSTED_VM/cloudinitRootPwd=bool:False
--
To view, visit https:/
Simone Tiraboschi has uploaded a new change for review.
Change subject: log: preventing boolean values to stop logging
..
log: preventing boolean values to stop logging
If one of the filtered keys assumes a boolean value otopi
s
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: adding DOCKERC_NEEDED
..
Patch Set 10: Verified+1
Verified on install, upgrade and remove
--
To view, visit https://gerrit.ovirt.org/4240
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: adding DOCKERC_NEEDED
..
Patch Set 8: -Verified
--
To view, visit https://gerrit.ovirt.org/42405
To unsubscribe, visit https://gerrit.ovir
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: adding DOCKERC_NEEDED
..
Patch Set 8: Verified+1
Verified on install, upgrade and remove
--
To view, visit https://gerrit.ovirt.org/42405
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: adding DOCKERC_NEEDED
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42405/1/packaging/setup/plugins/ovirt-engine-remove/docker
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure the appliance vCPU
value
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42158
To unsubsc
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: adding DOCKERC_NEEDED
..
packaging: setup: adding DOCKERC_NEEDED
Adding DOCKERC_NEEDED to enable dockerc related code under
engine-common
Simone Tiraboschi has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 24: Verified+1
The code to disable HE Local Maintenance mode is already in
backend/manager/modules/
Simone Tiraboschi has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 24: -Verified
Still an issue on re-deploy but I'm not sure it should be addressed here or on
engin
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: adding prepareImage to the connectStorage cmd
..
Patch Set 1: Verified+1
/var/run/vdsm/storage is now correctly populated also on additiona
Simone Tiraboschi has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 24: Verified+1
No it's also possible to re-deploy.
--
To view, visit https://gerrit.ovirt.org/385
Simone Tiraboschi has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 22:
Manually stopping ovirt-ha-agent and ovirt-ha-broker once in maintenance is
enough to let it d
Simone Tiraboschi has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 22:
From the agent logs:
MainThread::INFO::2015-06-15
18:28:18,067::hosted_engine::399::ovirt_hos
Simone Tiraboschi has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 22: Verified-1
Sorry, I found an issue.
First attempt works; putting in maintenance and re-deployi
Simone Tiraboschi has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 22: Verified+1
Verified manually adding
[environment:default]
HOSTED_ENGINE/enable=bool:true
H
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: adding prepareImage to the connectStorage cmd
..
packaging: setup: adding prepareImage to the connectStorage cmd
Now VDSM explictly needs
Simone Tiraboschi has posted comments on this change.
Change subject: removing service condition on vm.conf
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42389
To unsubscribe, visit https://gerrit.ovirt
Simone Tiraboschi has uploaded a new change for review.
Change subject: removing service condition on vm.conf
..
removing service condition on vm.conf
The agent will dinamically load vm.conf from the shared
storage domain so it
Simone Tiraboschi has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42342/1/src/ovirt_hosted_engine_setup/ovf/ovf2vmCon
Simone Tiraboschi has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42342/1/src/ovirt_hosted_engine_setup/ovf/ovf2vmCon
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: pki: Do not add empty lines to conf
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41786
To unsubscribe, visit h
Simone Tiraboschi has posted comments on this change.
Change subject: loading broker.conf and vm.conf from the shared storage
..
Patch Set 20:
> -1 just because I need one answer, otherwise it looks good.
>
> I wonder what w
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: moving vm.conf to /var/run
..
Patch Set 7: Verified+1
https://gerrit.ovirt.org/#/c/42234/
https://gerrit.ovirt.org/#/c/42233/
https://gerri
Simone Tiraboschi has posted comments on this change.
Change subject: loading broker.conf and vm.conf from the shared storage
..
Patch Set 20: Verified+1
https://gerrit.ovirt.org/#/c/42234/
https://gerrit.ovirt.org/#/c/42233/
h
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: removing local broker.conf
..
Patch Set 3: Verified+1
https://gerrit.ovirt.org/#/c/42234/
https://gerrit.ovirt.org/#/c/42233/
https://gerri
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: removing local broker.conf
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/42233/2/src/ovirt_hosted_engine_setup/constants.py
Fil
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: spec: drop all-in-one on el6 and fc20
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40162
To unsubscribe, visit https:
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: moving vm.conf to /var/run
..
packaging: setup: moving vm.conf to /var/run
The local filesystem vm.conf it's now just a temporary instance
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: removing local broker.conf
..
packaging: setup: removing local broker.conf
After https://gerrit.ovirt.org/#/c/42209/ the broker is also
ab
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: avoid copying answerfile over scp
..
Patch Set 2: Code-Review-1
We already have all the shared domain details cause we ask them to the user
Simone Tiraboschi has posted comments on this change.
Change subject: loading broker.conf from the shared storage
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/42209/6/ovirt-hosted-engine-ha.spec.in
File ovirt-hoste
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: saving the configuration on the shared domain
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/42052
To unsubscribe,
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: avoid copying answerfile over scp
..
packaging: setup: avoid copying answerfile over scp
On additional hosts:
- Reading hosted-engine.conf
Simone Tiraboschi has posted comments on this change.
Change subject: loading broker.conf from the shared storage
..
Patch Set 5:
> Please update the spec file so the package owns the statedir and
> the existing configuration
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: queryEnvKey: getHostname
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42199
To unsubscribe, visit https://gerr
Simone Tiraboschi has posted comments on this change.
Change subject: loading broker.conf from the shared storage
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/42209/3//COMMIT_MSG
Commit Message:
Line 7: loading b
Simone Tiraboschi has uploaded a new change for review.
Change subject: loading broker.conf from the shared storage
..
loading broker.conf from the shared storage
broker.conf is now on the shared storage and not on the
localfile
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: Small fix for queryPassword
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42161
To unsubscribe, visit https://g
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: saving the configuration on the shared domain
..
Patch Set 17: Verified+1
docstring only
--
To view, visit https://gerrit.ovirt.org/42052
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: honouring OVEHOSTED_VM/vmVCpus from answerfile
..
packaging: setup: honouring OVEHOSTED_VM/vmVCpus from answerfile
Let value from the answ
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: Add queryEnvKey
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42017
To unsubscribe, visit https://gerrit.ovirt.org/se
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: saving the configuration on the shared domain
..
Patch Set 16:
(2 comments)
https://gerrit.ovirt.org/#/c/42052/16/src/ovirt_hosted_engine_
Simone Tiraboschi has posted comments on this change.
Change subject: hosted-engine: allow to deploy hosted-engine
..
Patch Set 22:
Rebasing
--
To view, visit https://gerrit.ovirt.org/38547
To unsubscribe, visit https://gerri
Simone Tiraboschi has posted comments on this change.
Change subject: Add two new recover commands to the hosted-engine tool
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42093
To unsubscribe, visit
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: saving the configuration on the shared domain
..
Patch Set 15: Verified+1
Verified with
from ovirt_hosted_engine_setup import constants as
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: Add queryEnvKey
..
Patch Set 11:
(2 comments)
Really nice
https://gerrit.ovirt.org/#/c/42017/11/packaging/setup/ovirt_engine_setup/dialog.py
Fil
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: saving the configuration on the shared domain
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/42052/2/src/plugins/ovirt-hosted-en
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: saving the configuration on the shared domain
..
packaging: setup: saving the configuration on the shared domain
Creating an additional vo
Simone Tiraboschi has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41399
To unsubscribe, visit https://gerrit.o
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: auto-detect available appliance images and
suggest them
..
Patch Set 8: Verified+1
--== VM CONFIGURATION ==--
Please
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: auto-detect available appliance images and
suggest them
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/41987/4/src/plugins/ovi
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: auto-detect available appliance images and
suggest them
..
packaging: setup: auto-detect available appliance images and suggest them
Auto
Simone Tiraboschi has abandoned this change.
Change subject: core: [RFE]Hosted Engine add hosts with Web UI - Config
..
Abandoned
It seams that we found the way to save them on the shared storage
--
To view, visit https://ger
Simone Tiraboschi has abandoned this change.
Change subject: setup: adding broker.conf, answerfile and he conf as VdcOptions
..
Abandoned
It seams that we found the way to save them on the shared storage
--
To view, visit htt
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 30: Verified+1
Verified both on interactive and fully automated setup with accepta
Simone Tiraboschi has posted comments on this change.
Change subject: Add missing call to prepareImage
..
Patch Set 1: Verified+1
Verified on iSCSI
--
To view, visit https://gerrit.ovirt.org/41965
To unsubscribe, visit https:
Simone Tiraboschi has abandoned this change.
Change subject: packaging: setup: prepareImage before uploading
..
Abandoned
Fails, 41965 is working
--
To view, visit https://gerrit.ovirt.org/41964
To unsubscribe, visit https://
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: prepareImage before uploading
..
Patch Set 1: Verified-1
Fails also on iSCSI
--
To view, visit https://gerrit.ovirt.org/41964
To unsubscr
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: prepareImage before uploading
..
packaging: setup: prepareImage before uploading
Using HSM verb prepareImage before trying using it.
Chan
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 28:
(1 comment)
https://gerrit.ovirt.org/#/c/41357/28/src/plugins/ovirt-hosted-en
Simone Tiraboschi has posted comments on this change.
Change subject: setup: adding broker.conf, answerfile and he conf as VdcOptions
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41908/3/src/plugins/ovirt-hosted-en
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/41357/18/src/plugins/ovirt-hosted-en
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 25:
(3 comments)
https://gerrit.ovirt.org/#/c/41357/25/src/plugins/ovirt-hosted-e
Simone Tiraboschi has uploaded a new change for review.
Change subject: setup: adding broker.conf, answerfile and he conf as VdcOptions
..
setup: adding broker.conf, answerfile and he conf as VdcOptions
adding broker.conf, answe
Simone Tiraboschi has posted comments on this change.
Change subject: core: [RFE]Hosted Engine add hosts with Web UI - Config
..
Patch Set 2:
(1 comment)
> Can you elaborate how this patch is related to web UI ? I see only
>
Simone Tiraboschi has uploaded a new change for review.
Change subject: core: [RFE]Hosted Engine add hosts with Web UI - Config
..
core: [RFE]Hosted Engine add hosts with Web UI - Config
Hosted Engine additional hosts could be s
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: pki: Prompt before renewal
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41876
To unsubscribe, visit https://ge
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: pki: Prompt before renewal
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/41876/1/packaging/setup/plugins/ovirt-en
Simone Tiraboschi has posted comments on this change.
Change subject: restapi: avoid npe on floating disk creation without domain
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41621
To unsubscribe, v
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/41357/25/src/plugins/ovirt-hosted-en
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/41357/25/src/plugins/ovirt-hosted-en
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 25: Verified+1
Now I'm able to pass three DNS addresses and their configuration su
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 24:
If I try to add three DNS addresses it ignores them and I find
Cloud-init v.
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/41357/19/src/plugins/ovirt-hosted-en
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 19:
(2 comments)
https://gerrit.ovirt.org/#/c/41357/19/src/plugins/ovirt-hosted-e
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/41357/4/src/plugins/ovirt-hosted-eng
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/41357/19/src/plugins/ovirt-hosted-en
Simone Tiraboschi has posted comments on this change.
Change subject: sos: adapt to engine sosreport to sos 3.2
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41510
To unsubscribe, visit https://gerri
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 18:
(6 comments)
https://gerrit.ovirt.org/#/c/41357/18/src/plugins/ovirt-hosted-e
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 18: Verified+1
Verified
--== VM CONFIGURATION ==--
Simone Tiraboschi has posted comments on this change.
Change subject: sos: adapt to engine sosreport to sos 3.2
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41477
To unsubscribe, visit https://gerri
Simone Tiraboschi has posted comments on this change.
Change subject: config: fix exception handling
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41483
To unsubscribe, visit https://gerrit.ovirt.org
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 4:
(15 comments)
https://gerrit.ovirt.org/#/c/41357/4/src/ovirt_hosted_engine_set
Simone Tiraboschi has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41399/3/src/ovirt_hosted_engine_setup/check_liveliness.py
Fi
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: more descriptive error message for invalid
storage domain
..
packaging: setup: more descriptive error message for invalid storage domain
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: more descriptive error message for invalid
storage domain
..
packaging: setup: more descriptive error message for invalid storage domain
1 - 100 of 1125 matches
Mail list logo
