Simone Tiraboschi has posted comments on this change. Change subject: setup: adding broker.conf, answerfile and he conf as VdcOptions ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41908/3/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py File src/plugins/ovirt-hosted-engine-setup/core/answerfile.py: Line 23: Line 24: import datetime Line 25: import gettext Line 26: import os Line 27: import StringIO > I'd prefer to use io.StringIO since it will be python 3 ready. Done Line 28: Line 29: Line 30: from otopi import common Line 31: from otopi import constants as otopicons -- To view, visit https://gerrit.ovirt.org/41908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0cb56e316c1a621ac2934473fde23b636005cbc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
