Simone Tiraboschi has posted comments on this change. Change subject: log: preventing boolean values to stop logging ......................................................................
Patch Set 2: > and? what is the problem? After that otopi stops logging cause is filtering every single line. > how come you sometime store ohostedcons.CloudInit.ROOTPWD as string > and sometime as boolean?!?! > > please do not do these magics fix your code and avoid using magics. Personally I like this ternary conditions: None for unset/ask, bool:False for 'I don't want', any other string value for 'I want it with this value'. In that cloud-init configuration job I have different sub-features that are optional for instance at least: - the appliance root password - the appliance instance name - a static IP address for the appliance - a DNS server for the appliance ... And I really prefer avoiding using two distinct env keys (the boolean one for set or no, and the string one for the value) for each of them just cause: 1. on my opinion is more elegant but of course is opinable 2. it can be confusing for the user (you set OVEHOSTED_VM/cloudinitRootPwd and nothing happens cause you forgot to set also the correspondent bool value). By the way the issue (it stops logging) is still there if I just decide to filter a bool value without ever using it the same key to store a string. -- To view, visit https://gerrit.ovirt.org/42444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1709081bd2b4a99379a7ff9e20f4388aa187532 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
