Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: pki: Prompt before renewal ......................................................................
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/41876/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py: Line 449: ), Line 450: prompt=True, Line 451: default=None, Line 452: ) Line 453: self.environment[oenginecons.PKIEnv.RENEW] = renew You don't really need the renew variable Line 454: Line 455: @plugin.event( Line 456: stage=plugin.Stages.STAGE_MISC, Line 457: condition=lambda self: self.environment[oenginecons.PKIEnv.RENEW], -- To view, visit https://gerrit.ovirt.org/41876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca01632ac1ea7895bba54d7f3f8bb0d9b2c90d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
