Simone Tiraboschi has posted comments on this change. Change subject: log: preventing boolean values to stop logging ......................................................................
Patch Set 2: > I am unsure I understand when we have boolean keys in environment. OVEHOSTED_VM/cloudinitRootPwd is an instance. Setting the appliance root password via cloud-init is an optional feature and we also have to support full automation via answerfiles. So having OVEHOSTED_VM/cloudinitRootPwd=none:None means that is unset and so the setup should interactively, having instead OVEHOSTED_VM/cloudinitRootPwd=bool:False in the answerfile means the user explicitly doesn't want to set the appliance root password via cloud-init and so the setup should skip that configuration and also avoid asking again. The issue is that having a False there completely disables the logging capabilities. -- To view, visit https://gerrit.ovirt.org/42444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1709081bd2b4a99379a7ff9e20f4388aa187532 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
