Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: let the user configure engine VM networking ......................................................................
Patch Set 25: (1 comment) https://gerrit.ovirt.org/#/c/41357/25/src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py File src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py: Line 723: ohostedcons.CloudInit.VM_STATIC_CIDR Line 724: ]: Line 725: Line 726: if self.environment[ohostedcons.CloudInit.VM_DNS]: Line 727: fname = '/etc/sysconfig/network-scripts/ifcfg-eth0' > Currently on the ovirt-appliance it's named eth0. I think is a kind of clou Investigating it further, it seams that it depends just on the nic type and we are always creating the engine VM with virtio so it should be safe enough. Line 728: dnslist = [ Line 729: d.strip() Line 730: for d Line 731: in self.environment[ -- To view, visit https://gerrit.ovirt.org/41357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic09f4d92e44f1bf810f06ada703e533b8c5e2061 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
