Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: adding DOCKERC_NEEDED ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/42405/1/packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py File packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py: Line 58: ] Line 59: if self._enabled: Line 60: self.environment[ Line 61: odockerccons.ConfigEnv.DOCKERC_NEEDED Line 62: ] = True > Why not set it later, if user wanted to remove? Done Line 63: Line 64: @plugin.event( Line 65: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 66: name=odockerccons.Stages.REMOVE_CUSTOMIZATION_DOCKERC, https://gerrit.ovirt.org/#/c/42405/1/packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py File packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py: Line 89: ] Line 90: if self._enabled: Line 91: self.environment[ Line 92: odockerccons.ConfigEnv.DOCKERC_NEEDED Line 93: ] = True > Why not set it later, if user wanted to install? Done Line 94: Line 95: @plugin.event( Line 96: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 97: name=odockerccons.Stages.DOCKERC_CUSTOMIZE, -- To view, visit https://gerrit.ovirt.org/42405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I587c403072a4c2b690ed8fdadbfb386dbdde829f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
