Simone Tiraboschi has posted comments on this change.

Change subject: log: preventing boolean values to stop logging
......................................................................


Patch Set 2:

> there is no sense in filtering boolean values.
Why? 
 > also, your patch is fundamentally wrong as it solves your specific
 > use case with booleans.
I can agree on that, any suggestions?

-- 
To view, visit https://gerrit.ovirt.org/42444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1709081bd2b4a99379a7ff9e20f4388aa187532
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to