Simone Tiraboschi has posted comments on this change. Change subject: packaging: Add queryEnvKey ......................................................................
Patch Set 11: (2 comments) Really nice https://gerrit.ovirt.org/#/c/42017/11/packaging/setup/ovirt_engine_setup/dialog.py File packaging/setup/ovirt_engine_setup/dialog.py: Line 88: valid = True Line 89: for test in tests if tests else (): Line 90: try: Line 91: msg = test['test'](value) Line 92: except Exception: I'm not sure that catching all there is a good idea cause you risk to hide something, probably letting the developer catch the specific exception in the single test will be safer. Otherwise let it raise. Line 93: logger.debug('exception', exc_info=True) Line 94: msg = _('Failed') Line 95: if msg: Line 96: if interactive: Line 181: }, Line 182: { Line 183: 'test': password_hard_enough, Line 184: 'error': False, Line 185: 'warnmsg': 'Use weak password? ', Probably the warnmsg should like a bit different (at least not a question) if not interactive Line 186: }, Line 187: ), Line 188: ) Line 189: -- To view, visit https://gerrit.ovirt.org/42017 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c9f7f2fb7424bbeadd3779378ce042598ea0348 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
