Simone Tiraboschi has posted comments on this change. Change subject: Convert OVF to VDSM create parameters (vm.conf) ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42342/1/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py File src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py: Line 29: tmpdir, Line 30: ovfPath, Line 31: ) Line 32: ) Line 33: vmConf = {} This is an example of how currently vm.conf looks like. Probably it would be better to start from a template to get everything filled. vmId=67f3f110-f076-4802-b9e2-077a537849f4 memSize=4096 display=vnc devices={index:2,iface:ide,address:{ controller:0, target:0,unit:0, bus:1, type:drive},specParams:{},readonly:true,deviceId:fb67e5c3-0e90-4073-b5f7-a43933954f32,path:,device:cdrom,shared:false,type:disk} devices={index:0,iface:virtio,format:raw,poolID:00000000-0000-0000-0000-000000000000,volumeID:859a498a-5e7b-4dc0-af59-4de015c562ee,imageID:c00e477d-97bb-4cf9-95e0-a02232d84e26,specParams:{},readonly:false,domainID:906222d7-7337-4b0b-b5fe-45073b1c9590,optional:false,deviceId:c00e477d-97bb-4cf9-95e0-a02232d84e26,address:{bus:0x00, slot:0x06, domain:0x0000, type:pci, function:0x0},device:disk,shared:exclusive,propagateErrors:off,type:disk,bootOrder:1} devices={device:scsi,model:virtio-scsi,type:controller} devices={nicModel:pv,macAddr:00:16:3e:74:e7:71,linkActive:true,network:ovirtmgmt,filter:vdsm-no-mac-spoofing,specParams:{},deviceId:eac0fe39-42ad-4d54-880c-a014b6dbf7b5,address:{bus:0x00, slot:0x03, domain:0x0000, type:pci, function:0x0},device:bridge,type:interface} devices={device:console,specParams:{},type:console,deviceId:954ecc46-d57b-449a-ad7d-0a24f85faf1f,alias:console0} vmName=HostedEngine spiceSecureChannels=smain,sdisplay,sinputs,scursor,splayback,srecord,ssmartcard,susbredir smp=4 cpuType=SandyBridge emulatedMachine=pc Line 34: # general Line 35: vmConf['vmId'] = tree.find('Content/Section').attrib[OVF_NS + 'id'] Line 36: vmConf['vmName'] = tree.find('Content/Name').text Line 37: vmConf['display'] = DISPLAY_TYPES.get( -- To view, visit https://gerrit.ovirt.org/42342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7dd763dd701158e945ed2006520c6a073318d2c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
