Martin Mucha has posted comments on this change.
Change subject: engine: Introduce network attachments command
..
Patch Set 28:
(7 comments)
https://gerrit.ovirt.org/#/c/34971/28/backend/manager/modules/bll/src/main/java/org/o
Martin Mucha has posted comments on this change.
Change subject: core,restapi: allow indetifying network by its name when adding
network attachment allow indetifying network by its name.
..
Patch Set 16:
(3 comments)
https://
Martin Mucha has posted comments on this change.
Change subject: core: refactor&test for HostNetworkAttachmentsPersister
..
Patch Set 37:
(1 comment)
https://gerrit.ovirt.org/#/c/36067/37/backend/manager/modules/common/src/mai
Martin Mucha has posted comments on this change.
Change subject: core: refactored NetworkAttachmentCompleter + tests.
..
Patch Set 41:
(2 comments)
https://gerrit.ovirt.org/#/c/36142/41/backend/manager/modules/bll/src/main/jav
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 47:
(1 comment)
https://gerrit.ovirt.org/#/c/37154/47/backend/manager/modules/bll/src/main/java/org/ovir
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 47:
(6 comments)
https://gerrit.ovirt.org/#/c/37154/47/backend/manager/modules/bll/src/main/java/org/ovi
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce network attachments command
..
Patch Set 28:
(3 comments)
https://gerrit.ovirt.org/#/c/34971/28/backend/manager/modules/bll/src/main/java/org/o
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce network attachments command
..
Patch Set 28:
(3 comments)
https://gerrit.ovirt.org/#/c/34971/28/backend/manager/modules/bll/src/main/java/org/o
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce network attachments command
..
Patch Set 28:
(2 comments)
https://gerrit.ovirt.org/#/c/34971/28/backend/manager/modules/bll/src/main/java/org/o
Martin Mucha has posted comments on this change.
Change subject: engine: Remove nics from
CollectHostNetworkDataVdsCommandParameters
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/35377/27/backend/manager/modules/b
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 35:
(11 comments)
https://gerrit.ovirt.org/#/c/3/35/backend/manager/modules/bll/src/main/java/org/ov
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 35:
(5 comments)
https://gerrit.ovirt.org/#/c/3/35/backend/manager/modules/bll/src/main/java/org/ovi
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(2 comments)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/vdsbroker/src/main/java/o
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(1 comment)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/common/src/main/java/org/o
Martin Mucha has posted comments on this change.
Change subject: engine: Add query to retrieve host's bonds
..
Patch Set 27:
(2 comments)
https://gerrit.ovirt.org/#/c/35378/27/backend/manager/modules/bll/src/main/java/org/ovir
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(7 comments)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/bll/src/main/java/org/ovi
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(2 comments)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/bll/src/main/java/org/ovi
Martin Mucha has posted comments on this change.
Change subject: core: refactored gathering violations to separate class
..
Patch Set 48:
a) from OO point of view, it's nonsense for validator or TO of validationResuts
(Validat
Martin Mucha has posted comments on this change.
Change subject: core: refactored gathering violations to separate class
..
Patch Set 47:
(9 comments)
https://gerrit.ovirt.org/#/c/37154/47/backend/manager/modules/bll/src/main/
Martin Mucha has posted comments on this change.
Change subject: webadmin: offering files of unknown type as candidates for
kernel and initrd images
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/41358
Martin Mucha has posted comments on this change.
Change subject: webadmin: offering files of unknown type as candidates for
kernel and initrd images
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/41358/4/frontend/w
Martin Mucha has posted comments on this change.
Change subject: core: refactor&test for HostNetworkAttachmentsPersister
..
Patch Set 37:
(7 comments)
https://gerrit.ovirt.org/#/c/36067/37/backend/manager/modules/vdsbroker/src
Martin Mucha has posted comments on this change.
Change subject: engine: Add HostInterfaceValidator
..
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/34969/24/backend/manager/modules/dal/src/main/resources/bundles/AppE
Martin Mucha has posted comments on this change.
Change subject: engine: Add ModifiedNetworkAttachmentValidator
..
Patch Set 24:
this patch should be abandoned (I do not have privileges to do that). It's
content was either del
Martin Mucha has posted comments on this change.
Change subject: engine: Add ModifiedNetworkAttachmentValidator
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/34967/15/backend/manager/modules/bll/src/main/java/org/o
Martin Mucha has abandoned this change.
Change subject: core: tests for ModifiedNetworkAttachmentValidator
..
Abandoned
most methods removed, rest squashed into NetworkAttachmentValidator(est
--
To view, visit https://gerrit.
Martin Mucha has posted comments on this change.
Change subject: engine: Add ModifiedNetworkAttachmentValidator
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/34967/15/backend/manager/modules/bll/src/main/java/org/o
Martin Mucha has posted comments on this change.
Change subject: webadmin: offering files of unknown type as candidates for
kernel and initrd images
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/41358
Martin Mucha has posted comments on this change.
Change subject: userportal,webadmin: removed duplicates
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/41278
To unsubscribe, visit https://gerrit.ovirt.or
Martin Mucha has posted comments on this change.
Change subject: core: simplified refreshVdsmFileList unsuccessful call to vdsm
as well as returning null are considered to be invalid return values. Taking
advantage of it, if vds call is unsuccessful, it's pretended as if null was
returned inste
Martin Mucha has posted comments on this change.
Change subject: core: fixed visibility
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/41277
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerri
Martin Mucha has posted comments on this change.
Change subject: core: altered IsoDomainListSyncronizer to refresh and return
really *all* files if asked for it
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovir
Martin Mucha has posted comments on this change.
Change subject: core: error fix & simplification
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41271
To unsubscribe, visit https://gerrit.ovirt.org/setti
Martin Mucha has posted comments on this change.
Change subject: core: removed redundant initializers, unused parameters,
explicit type parameters
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/41272
To
Martin Mucha has posted comments on this change.
Change subject: core: refactored overgrown methods and calls
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/41274
To unsubscribe, visit https://gerrit.ovi
Martin Mucha has posted comments on this change.
Change subject: core: refactored 2 overgrown copy-pasted methods
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/41273
To unsubscribe, visit https://gerrit
Martin Mucha has posted comments on this change.
Change subject: engine: Add ModifiedNetworkAttachmentValidator
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/34967/15/backend/manager/modules/bll/src/main/java/org/o
Martin Mucha has posted comments on this change.
Change subject: core: Tests for NetworkAttachmentsValidator
..
Patch Set 40:
(6 comments)
https://gerrit.ovirt.org/#/c/36147/40/backend/manager/modules/bll/src/main/java/org/ovi
Martin Mucha has posted comments on this change.
Change subject: core: tests for NetworkAttachmentValidator
..
Patch Set 40:
(1 comment)
https://gerrit.ovirt.org/#/c/36570/40/backend/manager/modules/bll/src/test/java/org/ovirt
Martin Mucha has posted comments on this change.
Change subject: core: tests for NetworkAttachmentValidator
..
Patch Set 40:
(4 comments)
https://gerrit.ovirt.org/#/c/36570/40/backend/manager/modules/bll/src/test/java/org/ovir
Martin Mucha has posted comments on this change.
Change subject: core: simplified refreshVdsmFileList unsuccessful call to vdsm
as well as returning null are considered to be invalid return values. Taking
advantage of it, if vds call is unsuccessful, it's pretended as if null was
returned inste
Martin Mucha has posted comments on this change.
Change subject: core: refactored 2 overgrown copy-pasted methods
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/41273/4/backend/manager/modules/bll/src/main/java/org/o
Martin Mucha has posted comments on this change.
Change subject: core: refactor: renamed variables + extracted creating map
..
Patch Set 39:
(1 comment)
https://gerrit.ovirt.org/#/c/36145/39//COMMIT_MSG
Commit Message:
Line 5
Martin Mucha has abandoned this change.
Change subject: core: refactor: extracted uninteressant hashmap manipulation to
separate method
..
Abandoned
part replaced by MultiValueMapUtils, rest squashed to previous commit.
--
T
Martin Mucha has posted comments on this change.
Change subject: core: refactor: renamed variables + extracted creating map
..
Patch Set 39:
(2 comments)
https://gerrit.ovirt.org/#/c/36145/39/backend/manager/modules/bll/src/ma
Martin Mucha has posted comments on this change.
Change subject: core: tests for NetworkAttachmentValidator
..
Patch Set 40:
(8 comments)
https://gerrit.ovirt.org/#/c/36570/40/backend/manager/modules/bll/src/test/java/org/ovir
Martin Mucha has posted comments on this change.
Change subject: core: tests for NetworkAttachmentValidator
..
Patch Set 40:
(5 comments)
https://gerrit.ovirt.org/#/c/36570/40/backend/manager/modules/bll/src/test/java/org/ovir
Martin Mucha has posted comments on this change.
Change subject: core: tests for NetworkAttachmentValidator
..
Patch Set 40:
(9 comments)
https://gerrit.ovirt.org/#/c/36570/40/backend/manager/modules/bll/src/main/java/org/ovir
Martin Mucha has posted comments on this change.
Change subject: core: renamed method
..
Patch Set 40:
(1 comment)
https://gerrit.ovirt.org/#/c/36571/40/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/valid
Martin Mucha has posted comments on this change.
Change subject: core: refactor of HostNetworkAttachmentPersister
..
Patch Set 36:
(5 comments)
https://gerrit.ovirt.org/#/c/36141/36/backend/manager/modules/vdsbroker/src/main/j
Martin Mucha has posted comments on this change.
Change subject: core: refactored NetworkAttachmentCompleter + tests.
..
Patch Set 37:
(1 comment)
https://gerrit.ovirt.org/#/c/36142/37//COMMIT_MSG
Commit Message:
Line 6:
Lin
Martin Mucha has posted comments on this change.
Change subject: core: refactored NetworkAttachmentCompleter + tests.
..
Patch Set 37:
(6 comments)
https://gerrit.ovirt.org/#/c/36142/37/backend/manager/modules/bll/src/main/jav
Martin Mucha has posted comments on this change.
Change subject: core: refactor&test for HostNetworkAttachmentsPersister
..
Patch Set 37:
(6 comments)
https://gerrit.ovirt.org/#/c/36067/37/backend/manager/modules/vdsbroker/src
Martin Mucha has posted comments on this change.
Change subject: core: refactored HostSetupNetworksValidator to use
HostInterfaceValidator
..
Patch Set 32:
(6 comments)
https://gerrit.ovirt.org/#/c/35978/32/backend/manager/mo
Martin Mucha has posted comments on this change.
Change subject: core: validations from LabelNicCommand refactored out to
HostInterfaceValidator
..
Patch Set 30:
(6 comments)
https://gerrit.ovirt.org/#/c/35977/30/backend/mana
Martin Mucha has posted comments on this change.
Change subject: engine: Configure network on install with network attachments
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/34972/21/backend/manager/modules/bll/src/
Martin Mucha has posted comments on this change.
Change subject: restapi: Add support for Network Attachements.
..
Patch Set 38:
(7 comments)
https://gerrit.ovirt.org/#/c/32775/38/backend/manager/modules/bll/src/main/java/org/
Martin Mucha has posted comments on this change.
Change subject: engine: Add query to retrieve host's bonds
..
Patch Set 19:
(3 comments)
https://gerrit.ovirt.org/#/c/35378/19/backend/manager/modules/bll/src/main/java/org/ovir
Martin Mucha has posted comments on this change.
Change subject: engine: Remove nics from
CollectHostNetworkDataVdsCommandParameters
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/35377/19/backend/manager/modules/b
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(1 comment)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/vdsbroker/src/main/java/or
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(9 comments)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/bll/src/main/java/org/ovi
Martin Mucha has restored this change.
Change subject: core: validate that updated attachment already exists
..
Restored
--
To view, visit https://gerrit.ovirt.org/39500
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Mucha has abandoned this change.
Change subject: core: validate that updated attachment already exists
..
Abandoned
code added by this patch is duplicate; what it verifies is already verified.
--
To view, visit https:/
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(1 comment)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/bll/src/main/java/org/ovir
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce network attachments command
..
Patch Set 21:
(9 comments)
https://gerrit.ovirt.org/#/c/34971/21/backend/manager/modules/bll/src/main/java/org/o
Martin Mucha has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(36 comments)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/bll/src/main/java/org/ov
Martin Mucha has posted comments on this change.
Change subject: engine: Re-define HostSetupNetworks based on network attachments
..
Patch Set 32:
(2 comments)
https://gerrit.ovirt.org/#/c/32910/32/backend/manager/modules/comm
Martin Mucha has posted comments on this change.
Change subject: engine: Add NetworkAttachmentValidator
..
Patch Set 30:
ad: "Why are the tests in a much later patch? Please merge them to this patch."
— I just tried to change
Martin Mucha has posted comments on this change.
Change subject: engine: Re-define HostSetupNetworks based on network attachments
..
Patch Set 21:
(2 comments)
https://gerrit.ovirt.org/#/c/32910/21/backend/manager/modules/vdsb
Martin Mucha has posted comments on this change.
Change subject: core: removed redundant initializers, unused parameters,
explicit type parameters
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41272/2/backend/manag
Martin Mucha has posted comments on this change.
Change subject: engine: Add NetworkAttachment dao
..
Patch Set 29: Verified+1
--
To view, visit https://gerrit.ovirt.org/32581
To unsubscribe, visit https://gerrit.ovirt.org/set
Martin Mucha has uploaded a new change for review.
Change subject: restapi: refactored out updateActionTypeForQosType method
..
restapi: refactored out updateActionTypeForQosType method
• this code does not belong into update me
Martin Mucha has posted comments on this change.
Change subject: engine: Re-define HostSetupNetworks based on network attachments
..
Patch Set 27: Verified+1
--
To view, visit https://gerrit.ovirt.org/32910
To unsubscribe, vis
Martin Mucha has posted comments on this change.
Change subject: core: Extend Bond entity to contain slaves
..
Patch Set 27: Verified+1
--
To view, visit https://gerrit.ovirt.org/32909
To unsubscribe, visit https://gerrit.ovir
Martin Mucha has posted comments on this change.
Change subject: core: Introduce HostSetupNetworksParameters parameters
..
Patch Set 26: Verified+1
--
To view, visit https://gerrit.ovirt.org/32776
To unsubscribe, visit https:/
Martin Mucha has posted comments on this change.
Change subject: engine: Add NetworkAttachment dao
..
Patch Set 27: Verified+1
--
To view, visit https://gerrit.ovirt.org/32581
To unsubscribe, visit https://gerrit.ovirt.org/set
Martin Mucha has posted comments on this change.
Change subject: core: Introduce NetworkAttachment entity
..
Patch Set 22: Verified+1
--
To view, visit https://gerrit.ovirt.org/32411
To unsubscribe, visit https://gerrit.ovirt.
Martin Mucha has posted comments on this change.
Change subject: core: Introduce BusinessEntityMap
..
Patch Set 25: Verified+1
--
To view, visit https://gerrit.ovirt.org/33329
To unsubscribe, visit https://gerrit.ovirt.org/set
Martin Mucha has posted comments on this change.
Change subject: engine: Insufficient free macs while there is enough macs in
pool
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/39484
To unsubscribe, vi
Martin Mucha has posted comments on this change.
Change subject: core: fixed visibility
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41277
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerri
Martin Mucha has posted comments on this change.
Change subject: core: altered IsoDomainListSyncronizer to refresh and return
really *all* files if asked for it
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovir
Martin Mucha has posted comments on this change.
Change subject: userportal,webadmin: removed duplicates
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41278
To unsubscribe, visit https://gerrit.ovirt.or
Martin Mucha has posted comments on this change.
Change subject: webadmin: offering files of unknown type as candidates for
kernel and initrd images
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41358
Martin Mucha has posted comments on this change.
Change subject: core: refactored overgrown methods and calls
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41274
To unsubscribe, visit https://gerrit.ovi
Martin Mucha has posted comments on this change.
Change subject: core: refactored 2 overgrown copy-pasted methods
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41273
To unsubscribe, visit https://gerrit
Martin Mucha has posted comments on this change.
Change subject: core: todos
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41279
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageTy
Martin Mucha has posted comments on this change.
Change subject: core: simplified refreshVdsmFileList unsuccessful call to vdsm
as well as returning null are considered to be invalid return values. Taking
advantage of it, if vds call is unsuccessful, it's pretended as if null was
returned inste
Martin Mucha has uploaded a new change for review.
Change subject: webadmin: offering files of unknown type as candidates for
kernel and initrd images
..
webadmin: offering files of unknown type as candidates for kernel and init
Martin Mucha has uploaded a new change for review.
Change subject: core: fixed visibility
..
core: fixed visibility
Change-Id: Ia31d63a9281b337ad9f6e2c7fd09ce375b76992c
Signed-off-by: Martin Mucha
---
M
backend/manager/modules
Martin Mucha has uploaded a new change for review.
Change subject: userportal,webadmin: removed duplicates
..
userportal,webadmin: removed duplicates
• 2 duplicate anonymous IAsyncConverter class refactored to sole inner
class
•
Martin Mucha has uploaded a new change for review.
Change subject: core: error fix & simplification
..
core: error fix & simplification
• it seems that storage_pool_iso_map.status can be null, thus status
!= StorageDomainStatus.
Martin Mucha has uploaded a new change for review.
Change subject: core: refactored 2 overgrown copy-pasted methods
..
core: refactored 2 overgrown copy-pasted methods
Change-Id: Ide9f1559b7b36f2052c1beecc05bbc60b1c52a8b
Signed-
Martin Mucha has uploaded a new change for review.
Change subject: core: removed redundant initializers, unused parameters,
explicit type parameters
..
core: removed redundant initializers, unused parameters, explicit type
para
Martin Mucha has uploaded a new change for review.
Change subject: core: refactored overgrown methods and calls
..
core: refactored overgrown methods and calls
Change-Id: I0ec9c8ab12069851c623776ecdde69f07978b0ed
Signed-off-by:
Martin Mucha has uploaded a new change for review.
Change subject: core: simplified refreshVdsmFileList unsuccessful call to vdsm
as well as returning null are considered to be invalid return values. Taking
advantage of it, if vds call is unsuccessful, it's pretended as if null was
returned ins
Martin Mucha has uploaded a new change for review.
Change subject: core: altered IsoDomainListSyncronizer to refresh and return
really *all* files if asked for it
..
core: altered IsoDomainListSyncronizer to refresh and return r
Martin Mucha has posted comments on this change.
Change subject: core: Explicit type can be replaced with <> applied
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/38706
To unsubscribe, visit https://ge
Martin Mucha has posted comments on this change.
Change subject: webadmin: fix mac range validation not a ghost if at least one
boundary is set
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41109
To un
Martin Mucha has uploaded a new change for review.
Change subject: webadmin: fix mac range validation not a ghost if at least one
boundary is set
..
webadmin: fix mac range validation
not a ghost if at least one boundary is set
Martin Mucha has posted comments on this change.
Change subject: engine: Re-define HostSetupNetworks based on network attachments
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/32910/23/backend/manager/modules/vdsbr
1 - 100 of 979 matches
Mail list logo
