Martin Mucha has posted comments on this change. Change subject: core: tests for NetworkAttachmentValidator ......................................................................
Patch Set 40: (1 comment) https://gerrit.ovirt.org/#/c/36570/40/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java: Line 413: assertThat(new NetworkAttachmentValidator(attachment, null, managementNetworkUtil).networkNotChanged(oldAttachment), isValid()); Line 414: } Line 415: Line 416: @Test Line 417: public void testValidateGateway() throws Exception { > Please add more tests for this validation (valid, mutipleGateway enabled, n added, but I'm not sure, if method is actually ok (I'm not familiar with every aspect of its behavior). Can you verify it, please? Line 418: NetworkAttachment attachment = Line 419: createNetworkAttachmentWithIpConfiguration(NetworkBootProtocol.NONE, null, null); Line 420: Line 421: attachment.getIpConfiguration().getPrimaryAddress().setGateway("someGateway"); -- To view, visit https://gerrit.ovirt.org/36570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ba4327b93f8628e234e0e2b23234d8b89902b5 Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
