Martin Mucha has posted comments on this change. Change subject: core: refactored NetworkAttachmentCompleter + tests. ......................................................................
Patch Set 37: (1 comment) https://gerrit.ovirt.org/#/c/36142/37//COMMIT_MSG Commit Message: Line 6: Line 7: core: refactored NetworkAttachmentCompleter + tests. Line 8: Line 9: • added unit tests Line 10: • unfied implementation so both methods uses BusinessEntityMap > s/unfied/unified Done Line 11: • added tests for id<-->name coherence in case that user sets both. Line 12: • added completation of id in case that user specifies name of Line 13: existing bond/nic but does not specify id. Line 14: -- To view, visit https://gerrit.ovirt.org/36142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I933333afdcb11bfcf9f761572229f7a7a7814381 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
