Martin Mucha has posted comments on this change. Change subject: engine: Re-define HostSetupNetworks based on network attachments ......................................................................
Patch Set 21: (2 comments) https://gerrit.ovirt.org/#/c/32910/21/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java: Line 67: attributes.put(VdsProperties.NETWORK_CUSTOM_PROPERTIES, attachment.getProperties()); Line 68: } Line 69: Line 70: if (getParameters().getHostNetworkQosSupported()) { Line 71: NetworkQosMapper qosMapper = > Shouldn't you use HostNetworkQosMapper? (NetworkQosMapper is used for vnic Done Line 72: new NetworkQosMapper(attributes, Line 73: VdsProperties.HOST_QOS_INBOUND, Line 74: VdsProperties.HOST_QOS_OUTBOUND); Line 75: qosMapper.serialize(new NetworkQoS()); Line 71: NetworkQosMapper qosMapper = Line 72: new NetworkQosMapper(attributes, Line 73: VdsProperties.HOST_QOS_INBOUND, Line 74: VdsProperties.HOST_QOS_OUTBOUND); Line 75: qosMapper.serialize(new NetworkQoS()); > Not exactly. Please see the comments I've added to the attached patch. I tried to copy code from SetupNetworksVDSCommand.generateNetworks() to here, but it cannot be done without change, due to slightly different context; we're missing here some information. So instead, I altered HostNetwork to carry all that information to here from place, where it can be easily calculated. Touched patches by this are: this one, introduction of SetupHostNetworkCommand and introduction of QosDaoCache. Done. Line 76: } Line 77: Line 78: networks.put(attachment.getNetworkName(), attributes); Line 79: } -- To view, visit https://gerrit.ovirt.org/32910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75d02e4be71f00510bc8815c555a94d7efc9252e Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
