Martin Mucha has posted comments on this change. Change subject: engine: Introduce network attachments command ......................................................................
Patch Set 28: (3 comments) https://gerrit.ovirt.org/#/c/34971/28/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkAttachmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkAttachmentCommand.java: Line 28: addValidationGroup(UpdateEntity.class); Line 29: } Line 30: Line 31: @Override Line 32: protected boolean canDoAction() { > You have to add validation to make sure the passed attachment contains id ( Done Line 33: // VDS host = getVds(); Line 34: // Line 35: // List<String> hostValidationMessages = new HostValidator(host, isInternalExecution()).validate(); Line 36: // if (!hostValidationMessages.isEmpty()) { Line 29: } Line 30: Line 31: @Override Line 32: protected boolean canDoAction() { Line 33: // VDS host = getVds(); > Please remove the commented code. Done Line 34: // Line 35: // List<String> hostValidationMessages = new HostValidator(host, isInternalExecution()).validate(); Line 36: // if (!hostValidationMessages.isEmpty()) { Line 37: // getReturnValue().getCanDoActionMessages().addAll(hostValidationMessages); Line 61: propagateFailure(returnValue); Line 62: setSucceeded(returnValue.getSucceeded()); Line 63: } Line 64: Line 65: // private boolean validateCrossAttachments() { > Please remove the commented code. Done Line 66: // List<NetworkAttachment> expectedAttachments = getExpectedNetworkAttachments(); Line 67: // NetworkAttachmentsValidator crossAttachmentsValidator = Line 68: // new NetworkAttachmentsValidator(expectedAttachments, Line 69: // Entities.businessEntitiesById(getNetworkDAO().getAllForCluster(getVdsGroupId()))); -- To view, visit https://gerrit.ovirt.org/34971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1b7a4e0b5ceacf6ea436c4ede84e414817dbdd Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
