Martin Mucha has posted comments on this change. Change subject: engine: Introduce HostSetupNetworks command ......................................................................
Patch Set 26: (1 comment) https://gerrit.ovirt.org/#/c/33333/26/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java: Line 59: /** Line 60: * Adds new network attachments for reported networks from the host which weren't associated to a user attachment.<br> Line 61: * The network attachment's attributes will be inherited from the network interface on which it is configured. Line 62: */ Line 63: private void addNewNetworkAttachments() { > I'm not sure if it possible. But if you somehow get a network defined on to I hope got it right — there shouldn't be any network defined on slave; so we need not to create network attachment for them, since if they would have network attached, it will be an error. So if it's a slave of some bond, I'm skipping it as well. Done. Line 64: for (VdsNetworkInterface nic : nicsByName.values()) { Line 65: String networkName = nic.getNetworkName(); Line 66: if (networkName == null Line 67: || !clusterNetworks.containsKey(networkName) -- To view, visit https://gerrit.ovirt.org/33333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60077019f308f371f21fb7b5545ba48adb38bd06 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
