Martin Mucha has posted comments on this change. Change subject: engine: Add query to retrieve host's bonds ......................................................................
Patch Set 27: (2 comments) https://gerrit.ovirt.org/#/c/35378/27/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetHostBondsByHostIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetHostBondsByHostIdQuery.java: Line 17: } Line 18: Line 19: @Override Line 20: protected void executeQueryCommand() { Line 21: InterfaceDao interfaceDao = getDbFacade().getInterfaceDao(); > Please add- Done Line 22: List<VdsNetworkInterface> nics = interfaceDao.getAllInterfacesForVds(getParameters().getId()); Line 23: Map<String, List<String>> bondNameToSlavesMap = getBondNameToBondSlavesMap(nics); Line 24: for (VdsNetworkInterface nic : nics) { Line 25: if (nic.isBond()) { Line 29: } Line 30: } Line 31: } Line 32: Line 33: getQueryReturnValue().setReturnValue(nics); > Shouldn't you return just the bonds? Done Line 34: } Line 35: Line 36: private Map<String, List<String>> getBondNameToBondSlavesMap(List<VdsNetworkInterface> nics) { Line 37: Map<String, List<String>> bondToSlaves = new HashMap<>(); -- To view, visit https://gerrit.ovirt.org/35378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a632340312bc484c8e33699353b075aa45b1a4 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
