Martin Mucha has posted comments on this change. Change subject: webadmin: offering files of unknown type as candidates for kernel and initrd images ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/41358/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java: Line 799: params.setCustomProperties(getCustomPropertySheet().serialize()); Line 800: Line 801: // kernel params Line 802: String selectedKernelImage = getKernelImage().getSelectedItem(); Line 803: if (selectedKernelImage != null) { > please replace by StringUtils.isEmpty() Done Line 804: params.setKernelUrl(selectedKernelImage); Line 805: } Line 806: Line 807: if (getKernelParameters().getEntity() != null) { Line 808: params.setKernelParams(getKernelParameters().getEntity()); Line 809: } Line 810: Line 811: String selectedInitrdImage = getInitrdImage().getSelectedItem(); Line 812: if (selectedInitrdImage != null) { > same Done Line 813: params.setInitrdUrl(selectedInitrdImage); Line 814: } Line 815: Line 816: // Sysprep params -- To view, visit https://gerrit.ovirt.org/41358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5ce60fb187fbfd6efe1b6e497f21157bd7a9484 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
