Martin Mucha has posted comments on this change. Change subject: core: refactor&test for HostNetworkAttachmentsPersister ......................................................................
Patch Set 37: (1 comment) https://gerrit.ovirt.org/#/c/36067/37/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 543: NETWORK_NOT_EXISTS(ErrorType.BAD_PARAMETERS), Line 544: ACTION_TYPE_FAILED_NETWORK_QOS_NOT_EXISTS(ErrorType.BAD_PARAMETERS), Line 545: NETWORK_NOT_EXISTS_IN_CLUSTER(ErrorType.BAD_PARAMETERS), Line 546: NETWORK_ATTACHMENT_NOT_EXISTS(ErrorType.BAD_PARAMETERS), Line 547: NETWORK_ATTACHMENT_CONTAINS_DUPLICATES(ErrorType.BAD_PARAMETERS), > 1. The name here doesn't match the name in the AppErrors files- ACTION_TYPE ok. This is highly out of date. Validation name(…CONTAINS_DUPLICATES) was already fixed. Yet it's usages does not exist anymore, that's true. Method you refering to does not exist anymore as well.I cannot remember what was mine intent(correct or not), but relevant code was removed during CR. So I don't know what to do with this / what you want me to do. I'm suggesting removing this error message as well and forgetting about that there was once some validation. Line 548: NETWORK_ALREADY_ATTACHED_TO_HOST(ErrorType.CONFLICT), Line 549: NETWORK_OLD_NETWORK_NOT_SPECIFIED(ErrorType.BAD_PARAMETERS), Line 550: NETWORK_ALREADY_ATTACHED_TO_CLUSTER(ErrorType.CONFLICT), Line 551: NETWORK_CAN_NOT_REMOVE_DEFAULT_NETWORK(ErrorType.CONSTRAINT_VIOLATION), -- To view, visit https://gerrit.ovirt.org/36067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib39c3678a29a7bd8728d32b55490f8500a77d9d6 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
