Martin Mucha has posted comments on this change. Change subject: engine: Configure network on install with network attachments ......................................................................
Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/34972/21/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java: Line 63: Line 64: //TODO MM: management network by vdsGroup id. Which one is correct? By vdsGroup id or storagePool id? Line 65: this.managementNetwork = Line 66: // managementNetworkUtil.getManagementNetwork(host.getVdsGroupId()); Line 67: queryManagementNetwork(); > As you wrote in the comment, you should use the managementNetworkUtil.getMa Done Line 68: } Line 69: Line 70: public void createManagementNetworkIfRequired() { Line 71: if (host == null) { -- To view, visit https://gerrit.ovirt.org/34972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bdf4ddec4be8ded779e6f5f711b90099dce4054 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
