Martin Mucha has posted comments on this change. Change subject: engine: Introduce network attachments command ......................................................................
Patch Set 28: (2 comments) https://gerrit.ovirt.org/#/c/34971/28/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddNetworkAttachmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddNetworkAttachmentCommand.java: Line 33: } Line 34: Line 35: @Override Line 36: protected boolean canDoAction() { Line 37: // VDS host = getVds(); > Please remove the commented code. Done Line 38: // Line 39: // List<String> hostValidationMessages = new HostValidator(host, isInternalExecution()).validate(); Line 40: // if (!hostValidationMessages.isEmpty()) { Line 41: // getReturnValue().getCanDoActionMessages().addAll(hostValidationMessages); Line 80: Line 81: return createNetworkAttachment.getId(); Line 82: } Line 83: Line 84: // private boolean validateCrossAttachments() { > Please remove the commented code. Done Line 85: // List<NetworkAttachment> expectedAttachments = getDbFacade().getNetworkAttachmentDao().getAllForHost(getVdsId()); Line 86: // expectedAttachments.add(getParameters().getNetworkAttachment()); Line 87: // NetworkAttachmentsValidator crossAttachmentsValidator = Line 88: // new NetworkAttachmentsValidator(expectedAttachments, -- To view, visit https://gerrit.ovirt.org/34971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1b7a4e0b5ceacf6ea436c4ede84e414817dbdd Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
