[Engine-patches] Change in ovirt-engine[master]: restapi: Hook ID Comparison - minor code fix

2013-06-02 Thread oliel
Ori Liel has uploaded a new change for review. Change subject: restapi: Hook ID Comparison - minor code fix .. restapi: Hook ID Comparison - minor code fix Change-Id: I61084b7a1854a63f06820f1cb08de5df23ef38ec Signed-off-by: Ori

[Engine-patches] Change in ovirt-engine[master]: restapi: #838270 - Support View Of System Configuration

2013-06-02 Thread oliel
Ori Liel has posted comments on this change. Change subject: restapi: #838270 - Support View Of System Configuration .. Patch Set 11: (5 inline comments) File backend/manage

[Engine-patches] Change in ovirt-log-collector[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: modify copyright of base po .. Patch Set 1: (1 inline comment) File po/Makevars Line 17: # expected to

[Engine-patches] Change in ovirt-log-collector[master]: core: modify copyright of base po

2013-06-02 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: core: modify copyright of base po .. Patch Set 1: (1 inline comment) File po/Makevars Line 17: # expected

[Engine-patches] Change in ovirt-engine[master]: restapi - #755579: Return proper http status for errors

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi - #755579: Return proper http status for errors .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/2

[Engine-patches] Change in ovirt-engine[master]: packaging: fix file conflict when upgrading setup due to ver...

2013-06-02 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: fix file conflict when upgrading setup due to versionlock .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[engine_3.2]: tools: engine-setup - fixed installation messages

2013-06-02 Thread sbonazzo
Sandro Bonazzola has abandoned this change. Change subject: tools: engine-setup - fixed installation messages .. Patch Set 2: Abandoned No interest in having this in z stream -- To view, visit http://gerrit.ovirt.org/13321 To

[Engine-patches] Change in ovirt-engine[engine_3.2]: tools: engine-setup - Fixed memory requirements

2013-06-02 Thread sbonazzo
Sandro Bonazzola has abandoned this change. Change subject: tools: engine-setup - Fixed memory requirements .. Patch Set 1: Abandoned Not worth for z-stream -- To view, visit http://gerrit.ovirt.org/13323 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: webadmin: [WIP] host gluster-swift sub tab

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: [WIP] host gluster-swift sub tab .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/283/ : FAILU

[Engine-patches] Change in ovirt-engine[master]: webadmin: [WIP] host gluster-swift sub tab

2013-06-02 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: [WIP] host gluster-swift sub tab .. webadmin: [WIP] host gluster-swift sub tab Adding a new sub-tab "Gluster Swift" under Hosts. This will list all the

[Engine-patches] Change in ovirt-iso-uploader[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: I11ea0e9a840168d180182685078c9dcb43aa7bd5 Signed-off-by: Alon Bar-Lev --- M po

[Engine-patches] Change in ovirt-image-uploader[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: Id860018b4a5cfbfc17ead67e14270a1506f8ab78 Signed-off-by: Alon Bar-Lev --- M po

[Engine-patches] Change in ovirt-log-collector[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: Ieef2401dea531e7d264006f3cbdf40f44e3c2de1 Signed-off-by: Alon Bar-Lev --- M po

[Engine-patches] Change in ovirt-engine[master]: core : [WIP] Disk refactoring - DeviceDisk entity

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : [WIP] Disk refactoring - DeviceDisk entity .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/282/ :

[Engine-patches] Change in otopi[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: I5b2d97d18b2fac3a15920da1bb5f6fc547f336aa Signed-off-by: Alon Bar-Lev

[Engine-patches] Change in ovirt-host-deploy[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: modify copyright of base po .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15291 To unsubscribe, visit http:

[Engine-patches] Change in otopi[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: modify copyright of base po .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15292 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-host-deploy[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: I07d755cd498084d9ec1f8d48c2e4297ded8d2ee2 Signed-off-by: Alon Bar-Lev

[Engine-patches] Change in otopi[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: I5b2d97d18b2fac3a15920da1bb5f6fc547f336aa Signed-off-by: Alon Bar-Lev --- M po

[Engine-patches] Change in ovirt-host-deploy[master]: core: modify copyright of base po

2013-06-02 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: I07d755cd498084d9ec1f8d48c2e4297ded8d2ee2 Signed-off-by: Alon Bar-Lev --- M po

[Engine-patches] Change in ovirt-engine[master]: core: Introducing Batch updates to DAOs

2013-06-02 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Introducing Batch updates to DAOs .. Patch Set 5: I would prefer that you didn't submit this There's a whole lot of formatting "noise" in this patch, maki

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) Still failing on jenkins. .

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-02 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15077 To unsu

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-02 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 4: (2 inline comments) See question inline. Besides that, +1. ..

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-06-02 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 12: (1 inline comment) File backend/manager/modules/d

[Engine-patches] Change in ovirt-engine[master]: core : [WIP] Disk refactoring - DeviceDisk entity

2013-06-02 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core : [WIP] Disk refactoring - DeviceDisk entity .. Patch Set 1: Fails Currently fails some tests, please review, don't merge. -- To view, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core : [WIP] Disk refactoring - DeviceDisk entity

2013-06-02 Thread vvolansk
Vered Volansky has uploaded a new change for review. Change subject: core : [WIP] Disk refactoring - DeviceDisk entity .. core : [WIP] Disk refactoring - DeviceDisk entity The plugged property is a disk-vm property, and is irrel

[Engine-patches] Change in ovirt-engine[master]: core: Power Management failed if no proxy ...

2013-06-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Power Management failed if no proxy ... .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15274 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Add VDSM error message for local directory not found

2013-06-02 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Add VDSM error message for local directory not found .. Patch Set 2: @Tal - can you verify so we can move forward with this? -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: gluster: Added queries for service list

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added queries for service list .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/281/ : SUCCESS -

[Engine-patches] Change in ovirt-engine[master]: gluster: Added query for gluster cluster service

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added query for gluster cluster service .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/280/ : S

[Engine-patches] Change in ovirt-engine[master]: tools: expose GlusterRefreshRateHooks in engine-config

2013-06-02 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: tools: expose GlusterRefreshRateHooks in engine-config .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding EndExternalStepCommand

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding EndExternalStepCommand .. Patch Set 3: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovir

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding GetAllStepsQuery

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding GetAllStepsQuery .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/277/ : FAILURE --

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding GetMonitoredCommandsQuery

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding GetMonitoredCommandsQuery .. Patch Set 3: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/o

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding EndExternalJobCommand

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding EndExternalJobCommand .. Patch Set 3: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovirt

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding GetStepsByJobIdQuery

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding GetStepsByJobIdQuery .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/275/ : FAILURE

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding GetStepByStepIdQuery

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding GetStepByStepIdQuery .. Patch Set 3: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovirt_

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding ClearExternalJobCommand

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding ClearExternalJobCommand .. Patch Set 3: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovi

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding GetAllJobsQuery

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding GetAllJobsQuery .. Patch Set 3: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovirt_engin

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding AddExternalStepCommand

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding AddExternalStepCommand .. Patch Set 3: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovir

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding VdcObjectType, VdcActionType..

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding VdcObjectType, VdcActionType.. .. Patch Set 2: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: enable to inject a job in Execution..

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: enable to inject a job in Execution.. .. Patch Set 2: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding AddExternalJobCommand command

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding AddExternalJobCommand command .. Patch Set 2: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/j

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: adding jobId and stepId to VdcAction..

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: adding jobId and stepId to VdcAction.. .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/258/

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: DB, DAO and related BE patch for external..

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: DB, DAO and related BE patch for external.. .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: making CommandBase::getParameters()..

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: making CommandBase::getParameters().. .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/259/

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: RFE-Adding External Tasks Support

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: RFE-Adding External Tasks Support .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/257/ : FA

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: CommandBase modifications

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: CommandBase modifications .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/260/ : FAILURE -

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding GetAllJobsQuery

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Adding GetAllJobsQuery .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/253/ : FAILURE -- T

[Engine-patches] Change in ovirt-engine[master]: core: [WIP] handling memory snapshots on export/import vm

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: [WIP] handling memory snapshots on export/import vm .. Patch Set 6: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerr

[Engine-patches] Change in ovirt-engine[master]: core: Power Management failed if no proxy ...

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Power Management failed if no proxy ... .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/252/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory column to snapshot subtab

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add memory column to snapshot subtab .. Patch Set 9: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/249/ : F

[Engine-patches] Change in ovirt-engine[master]: core: [WIP] memory state handling on preview/commit/undo

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: [WIP] memory state handling on preview/commit/undo .. Patch Set 10: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerr

[Engine-patches] Change in ovirt-engine[master]: restapi: support for creating snapshot with memory

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: support for creating snapshot with memory .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/246/ :

[Engine-patches] Change in ovirt-engine[master]: core: [WIP] restore memory from snapshot on run vm

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: [WIP] restore memory from snapshot on run vm .. Patch Set 9: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/251/

[Engine-patches] Change in ovirt-engine[master]: core: remove memory image on remove snapshot

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: remove memory image on remove snapshot .. Patch Set 11: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/250/ : FA

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding ClearExternalJobCommand

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: Adding ClearExternalJobCommand .. Patch Set 1: (3 inline comments) File backend/manager/modules/bl

[Engine-patches] Change in ovirt-engine[master]: restapi: add memory attribute to snapshot

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: add memory attribute to snapshot .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/245/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: engine: Added provider name to NetworkView

2013-06-02 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Added provider name to NetworkView .. Patch Set 12: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11210 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: cleanup CreateVmVDSCommand

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup CreateVmVDSCommand .. Patch Set 6: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/243/ : FAILURE -- To

[Engine-patches] Change in ovirt-engine[master]: core: add memory volume to snapshot entity

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add memory volume to snapshot entity .. Patch Set 14: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/240/ : FAIL

[Engine-patches] Change in ovirt-engine[master]: engine: Add support for vNICs in OpenstackNetwork

2013-06-02 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Add support for vNICs in OpenstackNetwork .. Patch Set 17: (2 inline comments) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: core: extract general code from HibernateVmCommand

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: extract general code from HibernateVmCommand .. Patch Set 10: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/239

[Engine-patches] Change in ovirt-engine[master]: core: add memory snapshots capability to VdsBroker

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add memory snapshots capability to VdsBroker .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/238/

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory option to create snapshot popup

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add memory option to create snapshot popup .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/24

[Engine-patches] Change in ovirt-engine[master]: core: [WIP] remove memory from active snapshot

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: [WIP] remove memory from active snapshot .. Patch Set 6: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/242/ : F

[Engine-patches] Change in ovirt-engine[master]: core: add memory snapshot feature support

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add memory snapshot feature support .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/244/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: engine: Added provider network for run & stop VM

2013-06-02 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Added provider network for run & stop VM .. Patch Set 17: (3 inline comments) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: webadmin: preview snapshot with memory popup

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: preview snapshot with memory popup .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/237/ : FAI

[Engine-patches] Change in ovirt-engine[master]: restapi - #755579: Return proper http status for errors

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi - #755579: Return proper http status for errors .. Patch Set 4: I would prefer that you didn't submit this Build Unstable http://jenkins.ovir

[Engine-patches] Change in ovirt-engine[master]: core: save memory state on live snapshot with memory

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: save memory state on live snapshot with memory .. Patch Set 12: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/2

[Engine-patches] Change in ovirt-engine[master]: findbugs: dont use static filed as public

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: findbugs: dont use static filed as public .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/233/ : FAILUR

[Engine-patches] Change in ovirt-engine[master]: restapi: adding custom properties to vm interface

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: adding custom properties to vm interface .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/231/ :

[Engine-patches] Change in ovirt-engine[master]: restapi: Cannot remove custom properties from a vm

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Cannot remove custom properties from a vm .. Patch Set 5: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/232

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding EndExternalStepCommand

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: Adding EndExternalStepCommand .. Patch Set 1: (3 inline comments) File backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/230/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmNetworkInterface

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adds custom properties to VmNetworkInterface .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/229/

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding EndExternalJobCommand

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: Adding EndExternalJobCommand .. Patch Set 1: (2 inline comments) File backend/manager/modules/bll/

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding AddExternalStepCommand

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: Adding AddExternalStepCommand .. Patch Set 1: (3 inline comments) File backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Adding AddExternalJobCommand command

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: Adding AddExternalJobCommand command .. Patch Set 1: (1 inline comment) File backend/manager/modul

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: enable to inject a job in Execution..

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: enable to inject a job in Execution.. .. Patch Set 1: (1 inline comment) File backend/manager/modu

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: DB, DAO and related BE patch for external..

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: DB, DAO and related BE patch for external.. .. Patch Set 1: (4 inline comments) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: core: Changes type of VmDevice from String to enum

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Changes type of VmDevice from String to enum .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/227/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding custom properties to vnic dialog

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: adding custom properties to vnic dialog .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/228/ :

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: CommandBase modifications

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: CommandBase modifications .. Patch Set 1: (1 inline comment) File backend/manager/modules/bll/src/

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: RFE-Adding External Tasks Support

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: RFE-Adding External Tasks Support .. Patch Set 1: (1 inline comment) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: core: Power Management failed if no proxy ...

2013-06-02 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Power Management failed if no proxy ... .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/15274 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix NPE in VmModelBehaviorBase

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Fix NPE in VmModelBehaviorBase .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/222/ : FAILURE

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added the quota to the Pool-general subtab

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added the quota to the Pool-general subtab .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/22

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-06-02 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 13: Looks good to me, but someone else must approve (2 inline comments)

[Engine-patches] Change in ovirt-engine[master]: findbugs: convert to double on integer values before casting...

2013-06-02 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: findbugs: convert to double on integer values before casting them .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bu

[Engine-patches] Change in ovirt-engine[master]: core: fix typos in CanDoActionTestUtils

2013-06-02 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix typos in CanDoActionTestUtils .. Patch Set 2: (1 inline comment) For some reason I dropped my comment on line 32 - please see inline. Two of the thre

[Engine-patches] Change in ovirt-engine[master]: core: extract general code from HibernateVmCommand

2013-06-02 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: extract general code from HibernateVmCommand .. Patch Set 6: the comments in patch-set 6 were answered in patch-set 7 -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: extract general code from HibernateVmCommand

2013-06-02 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: extract general code from HibernateVmCommand .. Patch Set 7: (3 inline comments) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: core: add memory snapshots capability to VdsBroker

2013-06-02 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: add memory snapshots capability to VdsBroker .. Patch Set 7: (2 inline comments) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: core: add memory volume to snapshot entity

2013-06-02 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: add memory volume to snapshot entity .. Patch Set 10: (8 inline comments) @Allon, the memory volume is a comma-separated string of 6 uuids: ,. that way t

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL Missing 'fence_type' param - #969797

2013-06-02 Thread oliel
Ori Liel has uploaded a new change for review. Change subject: restapi: RSDL Missing 'fence_type' param - #969797 .. restapi: RSDL Missing 'fence_type' param - #969797 For .../api/hosts/xxx/fence - fence_type is a mandatory para

[Engine-patches] Change in ovirt-engine[master]: core: add memory volume to snapshot entity

2013-06-02 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: add memory volume to snapshot entity .. Patch Set 9: (1 inline comment) File backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: restapi - #755579: Return proper http status for errors

2013-06-02 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi - #755579: Return proper http status for errors .. Patch Set 3: i don't think other files should be moved as well (despite it's a right thing to do)

  1   2   3   >