Eli Mesika has posted comments on this change.
Change subject: [WIP] core: CommandBase modifications
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 306: getReturnValue().setDescription((tempVar != null) ? tempVar :
getReturnValue().getDescription());
Line 307: setActionMessageParameters();
Line 308: Step validatingStep=null;
Line 309: boolean actionAllowed = false;
Line 310: boolean isExternal = this.getParameters().getJobId() != null
|| this.getParameters().getStepId() != null;
Its simple , internal has null job/step ids , external have one of them set
About the method , I didn't want it to conflict/mixed with the AuditLogableBase
isExternal method , therefor I think as is it is more clear
Line 311: if (!isExternal) {
Line 312: validatingStep =
ExecutionHandler.addStep(getExecutionContext(), StepEnum.VALIDATING, null);
Line 313: }
Line 314:
--
To view, visit http://gerrit.ovirt.org/15220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6350853f66e8f117dc3ebf8ff3e346bb9b241ad
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
