Eli Mesika has posted comments on this change.
Change subject: [WIP] core: Adding EndExternalJobCommand
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java
Line 22:
Line 23: @Override
Line 24: protected boolean canDoAction() {
Line 25: boolean retValue=true;
Line 26: job =
DbFacade.getInstance().getJobDao().get(getParameters().getJobId());
Done
Line 27: if (job == null) {
Line 28: retValue = false;
Line 29: //TODO message
Line 30: }
Line 42: }
Line 43:
Line 44: @Override
Line 45: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 46: // TODO Auto-generated method stub
Done
Line 47: return null;
Line 48: }
Line 49:
--
To view, visit http://gerrit.ovirt.org/15228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d8643e32eaecf79ac769c3b6eacef9e6330c512
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
