Eli Mesika has posted comments on this change.
Change subject: [WIP] core: Adding AddExternalStepCommand
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java
Line 23:
Line 24: @Override
Line 25: protected boolean canDoAction() {
Line 26: boolean retValue=true;
Line 27: job =
DbFacade.getInstance().getJobDao().get(getParameters().getId());
Done
Line 28: if (job != null) {
Line 29: if (!job.isExternal()) {
Line 30: retValue = false;
Line 31: //TODO message
Line 52: context.setMonitored(true);
Line 53: if (parentStep == null) { // A step that is directly under a
job
Line 54: context.setJob(job);
Line 55: context.setExecutionMethod(ExecutionMethod.AsJob);
Line 56: Step step =
ExecutionHandler.addStep(context,StepEnum.EXECUTING,
getParameters().getDescription(), true);
The canDoAction will throw you out , we need the id for displaying in the right
hierarchy
Line 57: setActionReturnValue(step.getId());
Line 58: setSucceeded(true);
Line 59: }
Line 60: else {// this is a sub-step
Line 67: }
Line 68:
Line 69: @Override
Line 70: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 71: // TODO Auto-generated method stub
Done
Line 72: return null;
Line 73: }
Line 74:
--
To view, visit http://gerrit.ovirt.org/15227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I014a4911873ebe7c8dc37b6504655b377d73da3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
