Moti Asayag has posted comments on this change.
Change subject: engine: Added provider network for run & stop VM
......................................................................
Patch Set 17: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 469: Network network = (networkName == null) ? null :
clusterNetworks.get(networkName);
Line 470: if (network != null
Line 471: && network.getProvidedBy() != null
Line 472: && nicDevices.get(new VmDeviceId(iface.getId(),
getVmId())).getIsPlugged()
Line 473: && iface.isLinked()) {
according to the wiki there is an assumption that the external network cannot
be unlinked. Shouldn't it be enforced by AddVnic/UpdateVnic rather than
validating it here ?
Line 474: NetworkProviderProxy providerProxy =
Line 475:
ProviderProxyFactory.getInstance().create(getDbFacade().getProviderDao().get(
Line 476:
network.getProvidedBy().getProviderId()));
Line 477: String propertyValue =
providerProxy.allocate(network, iface);
Line 475:
ProviderProxyFactory.getInstance().create(getDbFacade().getProviderDao().get(
Line 476:
network.getProvidedBy().getProviderId()));
Line 477: String propertyValue =
providerProxy.allocate(network, iface);
Line 478: if (propertyValue != null) {
Line 479:
getVm().getRuntimeCustomProperties().put("quantumvnic_" +
iface.getMacAddress(), propertyValue);
how about extracting "quantumvnic_" into a constant?
Line 480: }
Line 481: }
Line 482: }
Line 483: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java
Line 61: }
Line 62:
Line 63: private static void handleProviderNetworks(Guid vmId) {
Line 64: List<VmNetworkInterface> interfaces =
DbFacade.getInstance().getVmNetworkInterfaceDao().getAllForVm(vmId);
Line 65: VM vm = DbFacade.getInstance().getVmDao().get(vmId);
VmStatic via VmStaticDao seems sufficient for the needs of this method.
Line 66: Map<String, Network> clusterNetworks =
Line 67:
Entities.entitiesByName(DbFacade.getInstance().getNetworkDao().getAllForCluster(vm.getVdsGroupId()));
Line 68:
Line 69: for (VmNetworkInterface iface : interfaces) {
--
To view, visit http://gerrit.ovirt.org/11032
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b100ddad9ea88e07980ada116c19e42ca2b2c8a
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
