Eli Mesika has posted comments on this change.
Change subject: [WIP] core: enable to inject a job in Execution..
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 210: private static Job getJob(CommandBase<?> command, VdcActionType
actionType) {
Line 211: VdcActionParametersBase params = command.getParameters();
Line 212: Job job;
Line 213: // if Job is external, we had already created the Job by
AddExternalJobCommand, so just get it from DB
Line 214: if (params.getJobId() != null) {
why not in VdcActionParametersBase itself ???
Line 215: job =
DbFacade.getInstance().getJobDao().get((Guid)params.getJobId());
Line 216: }
Line 217: else {
Line 218: job = createJob(actionType, command);
--
To view, visit http://gerrit.ovirt.org/15224
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e2fb56663ca730b3fb98ad53e653d3584857540
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
