Eli Mesika has posted comments on this change.
Change subject: [WIP] core: Adding ClearExternalJobCommand
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java
Line 7: import org.ovirt.engine.core.common.job.Job;
Line 8: import org.ovirt.engine.core.compat.Guid;
Line 9: import org.ovirt.engine.core.dal.dbbroker.DbFacade;
Line 10:
Line 11: public class ClearExternalJobCommand <T extends
VdcActionParametersBase> extends CommandBase<T>{
Done
Line 12:
Line 13: private Job job;
Line 14: public ClearExternalJobCommand(T parameters) {
Line 15: super(parameters);
Line 17:
Line 18: @Override
Line 19: protected boolean canDoAction() {
Line 20: boolean retValue = true;
Line 21: if (getParameters().getJobId() != null) {
Sure , those are actually marked with the TODO , I will add that in later
patches
Line 22: job = DbFacade.getInstance().getJobDao().get((Guid)
getParameters().getJobId());
Line 23: if (job == null) {
Line 24: retValue = false;
Line 25: // TODO message
Line 17:
Line 18: @Override
Line 19: protected boolean canDoAction() {
Line 20: boolean retValue = true;
Line 21: if (getParameters().getJobId() != null) {
Looked at that , have several questions , will ask Moti how to implement
Line 22: job = DbFacade.getInstance().getJobDao().get((Guid)
getParameters().getJobId());
Line 23: if (job == null) {
Line 24: retValue = false;
Line 25: // TODO message
--
To view, visit http://gerrit.ovirt.org/15230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91605498
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
