Arik Hadas has posted comments on this change.

Change subject: core: add memory snapshots capability to VdsBroker
......................................................................


Patch Set 7: (2 inline comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SnapshotVDSCommandParameters.java
Line 5: import org.ovirt.engine.core.common.businessentities.DiskImage;
Line 6: import org.ovirt.engine.core.compat.Guid;
Line 7: 
Line 8: public class SnapshotVDSCommandParameters extends 
VdsAndVmIDVDSParametersBase {
Line 9:     /** Those are the disks images that snapshot should be taken for */
Done
Line 10:     private List<DiskImage> images;
Line 11:     /** String representation of the volume in which the memory will 
be dump to */
Line 12:     private String memoryVolume;
Line 13: 


....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SnapshotVDSCommand.java
Line 41:             Map<String, String> imageParams = new HashMap<String, 
String>();
Line 42:             imageParams.put("domainID",     
image.getStorageIds().get(0).toString());
Line 43:             imageParams.put("imageID",      
image.getimage_group_id().toString());
Line 44:             imageParams.put("baseVolumeID", 
image.getParentId().toString());
Line 45:             imageParams.put("volumeID",     
image.getImageId().toString());
Done
Line 46:             result[i] = imageParams;
Line 47:         }
Line 48: 
Line 49:         return result;


--
To view, visit http://gerrit.ovirt.org/14201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id928c76562d520acbf36ca01e074e51cbdcccaf9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to