Arik Hadas has posted comments on this change.
Change subject: core: extract general code from HibernateVmCommand
......................................................................
Patch Set 7: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 528: * or null if no such storage domain exists in the pool
Line 529: */
Line 530: public static StorageDomain findStorageDomainForMemory(Guid
storagePoolId, long sizeRequested) {
Line 531: List<StorageDomain> domainsInPool =
DbFacade.getInstance().getStorageDomainDao().getAllForStoragePool(storagePoolId);
Line 532: if (domainsInPool.size() > 0) {
Done (it was just copy-paste from other place..)
Line 533: for (StorageDomain currDomain : domainsInPool) {
Line 534: if
((currDomain.getStorageDomainType().equals(StorageDomainType.Master)
Line 535: ||
currDomain.getStorageDomainType().equals(StorageDomainType.Data))
Line 536: && currDomain.getStatus() ==
StorageDomainStatus.Active
Line 531: List<StorageDomain> domainsInPool =
DbFacade.getInstance().getStorageDomainDao().getAllForStoragePool(storagePoolId);
Line 532: if (domainsInPool.size() > 0) {
Line 533: for (StorageDomain currDomain : domainsInPool) {
Line 534: if
((currDomain.getStorageDomainType().equals(StorageDomainType.Master)
Line 535: ||
currDomain.getStorageDomainType().equals(StorageDomainType.Data))
I would but I can't find this method.. are you sure it should be in
StorageDomainType?
Line 536: && currDomain.getStatus() ==
StorageDomainStatus.Active
Line 537: &&
doesStorageDomainhaveSpaceForRequest(currDomain, sizeRequested)) {
Line 538: return currDomain;
Line 539: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1458: * @return - Memory size for allocation in bytes.
Line 1459: */
Line 1460: @JsonIgnore
Line 1461: public long getTotalMemorySizeInBytes() {
Line 1462: return (long) (getVmMemSizeMb() + 200 + (64 *
getNumOfMonitors())) * 1024 * 1024;
I'm not sure I understand it - it was copied from hibernation command as the
dumped memory should be the same. regarding the overflow, theoretically you're
right, but I think that in practice there's an assumption that
"getVmMemSizeMb() + 200 + (64 * getNumOfMonitors())" is an int (assuming the
memory size in mb is bounded to int and the number of monitors is not that
much) and then it's enough to convert this result to long
Line 1463: }
Line 1464:
Line 1465: ///////////////////////////////////////////////
Line 1466: /// Utility methods that check the VM state ///
--
To view, visit http://gerrit.ovirt.org/14290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15c4f3302d26eb5d161824f8bb19ecc5dd114a20
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
