Allon Mureinik has posted comments on this change.
Change subject: core: Fix findbugs to conform to mvn 3.0
......................................................................
Patch Set 4: (2 inline comments)
See question inline.
Besides that, +1.
....................................................
File backend/manager/modules/bll/pom.xml
Line 213: </archive>
Line 214: </configuration>
Line 215: </plugin>
Line 216:
Line 217: <plugin>
Question: shouldn't we define this in the head pom.xml, and have every other
module inherit it?
Nitpicking: The indentation seems to be off here, unless it's a gerrit foobar.
Please fix.
Line 218: <groupId>org.codehaus.mojo</groupId>
Line 219: <artifactId>findbugs-maven-plugin</artifactId>
Line 220: <version>${findbugs.version}</version>
Line 221: <configuration>
....................................................
Commit Message
Line 6:
Line 7: core: Fix findbugs to conform to mvn 3.0
Line 8:
Line 9: In order to run mvn findbugs:findbugs,
Line 10: the findbugs plufing configuration must exist at the
s/plufing/plugin, I assume?
Line 11: "build" section
Line 12:
Line 13: Change-Id: Id674955625a14c6e02a579fe2f132f64a8db9cc2
--
To view, visit http://gerrit.ovirt.org/15077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id674955625a14c6e02a579fe2f132f64a8db9cc2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
