Moti Asayag has posted comments on this change.
Change subject: engine: Add support for vNICs in OpenstackNetwork
......................................................................
Patch Set 17: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
Line 92:
Line 93: Port createdPort = getQuantumClient().execute(new
CreatePort(port));
Line 94: return createdPort.getId();
Line 95: } catch (RuntimeException e) {
Line 96: throw new VdcBLLException(VdcBllErrors.PROVIDER_FAILURE,
new RuntimeException(e));
why not just pass 'e' instead of wrapping it with a new exception ?
Line 97: }
Line 98: }
Line 99:
Line 100: @Override
Line 106: getQuantumClient().execute(new
DeletePort(port.getId()));
Line 107: }
Line 108: }
Line 109: } catch (RuntimeException e) {
Line 110: throw new VdcBLLException(VdcBllErrors.PROVIDER_FAILURE,
new RuntimeException(e));
same as above
Line 111: }
Line 112: }
--
To view, visit http://gerrit.ovirt.org/11110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I465dee81c3348a3f49ff41a8983a8ba2c8d43fad
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
