Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 11: Verified
Addressed Ayal and Vered's comments.
Answered inline in previous patchset where additi
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 10: (1 inline comment)
File
backend/manager/m
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 10: (4 inline comments)
File
backend/manager/
Eyal, for some reason the build times out:
> [ERROR] Failed to execute goal
> org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs (default-cli)
> on project bll: Execution default-cli of goal
> org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs failed:
> Timeout: killed the sub-process -> [H
Greg Padgett has posted comments on this change.
Change subject: [WIP] core, webadmin, restapi: Add CPU overcommitment
..
Patch Set 1:
Accompanying vdsm patch at http://gerrit.ovirt.org/#/c/10144/
--
To view, visit http://gerr
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3002/
Build Number: 3002
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,637
-
Changes Since La
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 10: (2 inline comments)
File
backend/manager/modu
Eli Mesika has submitted this change and it was merged.
Change subject: core: fix a typo in ErrorTranslatorImpl code
..
core: fix a typo in ErrorTranslatorImpl code
This patch fixes a typo in ErrorTranslatorImpl code
replaces t
Eli Mesika has posted comments on this change.
Change subject: core: fix a typo in ErrorTranslatorImpl code
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9686
To unsubscribe, vis
Arik Hadas has posted comments on this change.
Change subject: restapi,engine: fix usb mapping on update vm call
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Vered Volansky has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 10: (2 inline comments)
File
backend/manager/
Arik Hadas has posted comments on this change.
Change subject: userportal: allow connection to guest with non resp agent
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10030
To unsubscribe, visit http://gerr
Arik Hadas has posted comments on this change.
Change subject: userportal: allow connection to guest with non resp agent
..
Patch Set 1: (1 inline comment)
File
frontend/web
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3001/
Build Number: 3001
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,636
-
Changes Since
Eli Mesika has submitted this change and it was merged.
Change subject: core: Add support for iLO2 and iLO4 as...(#837907)
..
core: Add support for iLO2 and iLO4 as...(#837907)
Add support for iLO2 and iLO4 as a fencing options
Eli Mesika has posted comments on this change.
Change subject: core: Add support for iLO2 and iLO4 as...(#837907)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8492
To unsubscrib
Alissa Bonas has posted comments on this change.
Change subject: core: ValidationResult private default constructor
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10142
Eli Mesika has posted comments on this change.
Change subject: core: Add support for iLO2 and iLO4 as...(#837907)
..
Patch Set 1: Verified; Looks good to me, approved
verified for regressions , will be tested by QA that has tho
Allon Mureinik has posted comments on this change.
Change subject: core: ValidationResult private default constructor
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10142
To unsubscribe, visit http://gerrit.
Allon Mureinik has uploaded a new change for review.
Change subject: core: ValidationResult private default constructor
..
core: ValidationResult private default constructor
ValidationResult's default constructor should be priva
Allon Mureinik has posted comments on this change.
Change subject: core: add toString method to VM and VDS
..
Patch Set 5: Looks good to me, but someone else must approve
Looks great to me, giving +1 and not +2 just to leave Ya
Allon Mureinik has posted comments on this change.
Change subject: core: remove redundant constructors from VmStatistics
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9294
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm: fix disk alias generation
..
Patch Set 13: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9629
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm: Add test for addImagesAndSnapshots
..
Patch Set 13: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9630
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm: disk alias with copyCollapse=false
..
Patch Set 15: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9631
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler.setDiskAlias early return
..
Patch Set 11: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9658
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: error instead of errorFormat
..
Patch Set 6: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9797
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test: activate insufficientDiskSpace
..
Patch Set 13: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9628
To unsub
Allon Mureinik has posted comments on this change.
Change subject: core: GetAllFromExportDomainQueryParameters.getAll
..
Patch Set 11: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9625
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: Don't mock DAOs
..
Patch Set 13: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9626
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: Remove TestHelperImportVm
..
Patch Set 13: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9627
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction
..
Patch Set 11: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9623
To unsubscribe, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoActionXXX conventions
..
Patch Set 11: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9624
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: CDA_afterCloneVm signature
..
Patch Set 4: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/10007
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction_beforeCloneVM
..
Patch Set 11: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9621
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: CDA_beforeCloneVm sig.
..
Patch Set 4: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/10006
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction_afterCloneVm
..
Patch Set 11: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9622
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: action and type params
..
Patch Set 11: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9620
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/9619
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 10:
Changed the way names were generated in this test, following feedback from Ayal
and Vered on p
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
..
Patch Set 10:
Changed the way names were generated in this test, following feedback from Ayal
and Vered on p
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVm test cleanup: stop spying
..
core: ImportVm test cleanup: stop spying
Removed useless calls to Mockito.spy(), which simply spied objects
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: stop spying
..
Patch Set 9: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by derez.
--
To view, visit http://g
Daniel Erez has posted comments on this change.
Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9724
To unsubscribe, visi
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(6).
..
core:StorageHelper Cleanup, method name standard(6).
Change method name connectStorageToDomainByVdsId to
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Use storage helper to fetch (related to BZ882825)
..
core: Use storage helper to fetch (related to BZ882825)
Added engine support for connecting LUN with m
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(11).
..
core:StorageHelper Cleanup, method name standard(11).
Change method name getStorageServerConnectionsByDo
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper cleanup, code clean
..
core:StorageHelper cleanup, code clean
Refactor implementation of runForSingleConnectionInHost to be more short
and rea
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper cleanup, use one log declaration.
..
core:StorageHelper cleanup, use one log declaration.
Declare log only at StorageHelperBase instead in eac
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper cleanup,Remove unused method.
..
core:StorageHelper cleanup,Remove unused method.
Remove unused method.
Change-Id: Ibeb4d32a82c78b4a269906560
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(8).
..
core:StorageHelper Cleanup, method name standard(8).
Change method name connectStorageToLunByVdsId to be
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(10).
..
core:StorageHelper Cleanup, method name standard(10).
Change method name ValidateStoragePoolConnectionsI
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper clenups, Use formatter.
..
core:StorageHelper clenups, Use formatter.
Use formatter in storage helper classes.
Change-Id: I7c141cf02d7a98f3e4
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(12).
..
core:StorageHelper Cleanup, method name standard(12).
Change method name isConnectSucceeded to be
compat
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(9).
..
core:StorageHelper Cleanup, method name standard(9).
Change method name storageDomainRemoved to be
compat
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(4).
..
core:StorageHelper Cleanup, method name standard(4).
Change method name RunConnectionStorageToDomain to b
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(3).
..
core:StorageHelper Cleanup, method name standard(3).
Change method name runForSingleConnectionInHost to b
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(7).
..
core:StorageHelper Cleanup, method name standard(7).
Change method name disconnectStorageFromDomainByVdsI
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(2).
..
core:StorageHelper Cleanup, method name standard(2).
Change method name DisconnectStorageFromDomainByStor
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(7).
..
core:StorageHelper Cleanup, method name standard(7).
Change method name disconnectStorageFromLunByVdsId t
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(1).
..
core:StorageHelper Cleanup, method name standard(1).
Change method name ConnectStorageToDomainByStoragePo
Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(4).
..
core:StorageHelper Cleanup, method name standard(4).
Change method name RunConnectionStorageToDomain to b
Muli Salem has uploaded a new change for review.
Change subject: engine: Update VmGuestAgentInterfaces
..
engine: Update VmGuestAgentInterfaces
This patch changes the objects that are returned from
GetAllVmStats and GetVmStats t
Alissa Bonas has posted comments on this change.
Change subject: core: ImagesHandler: error instead of errorFormat
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9797
T
Eli Mesika has posted comments on this change.
Change subject: core : implementing AddExternalEventCommand ...
..
Patch Set 1: (3 inline comments)
File
backend/manager/modul
Liron Aravot has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
..
Patch Set 21: (3 inline comments)
File
bac
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 19: (8 inline comments)
File backend/manager/dbscripts/storages_
Ori Liel has abandoned this change.
Change subject: restapi: Remove Interfering Tab From Yaml File
..
Patch Set 1: Abandoned
already fixed by another patch
--
To view, visit http://gerrit.ovirt.org/9795
To unsubscribe, visit h
ofri masad has uploaded a new change for review.
Change subject: core: Quota Monitors - backend
..
core: Quota Monitors - backend
This patch is the 1st out of 3.
It sets the backend support for adding Quota Monitoring to the UI
ofri masad has uploaded a new change for review.
Change subject: webadmin: Quota Monitors - webadmin
..
webadmin: Quota Monitors - webadmin
This patch is the 2nd out of 3.
Quota monitoring is added to the webadmin as columns in
Ori Liel has posted comments on this change.
Change subject: cli: auto complete suggests "from_event_id" while it shouldnt
#886792
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Ori Liel has posted comments on this change.
Change subject: cli: filter out _Base__context prop in txt formating
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10101
T
Ori Liel has posted comments on this change.
Change subject: cli: negative numbers wrapped as strings #880216
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10100
To un
Eli Mesika has posted comments on this change.
Change subject: API: [RFE] Add PM Proxy Preferences
..
Patch Set 3: (4 inline comments)
File
backend/manager/modules/restapi/i
Ori Liel has posted comments on this change.
Change subject: cli: missing acknowledgement for remove commands #886941
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/100
Doron Fediuck has posted comments on this change.
Change subject: engine: cpu host feature
..
Patch Set 13: (1 inline comment)
File
backend/manager/modules/restapi/interface
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2897/
Build Number: 2897
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,633,
Started by upstream project "ovirt_engine" build nu
Mike Kolesnik has posted comments on this change.
Change subject: core : add NetwrokLinking support to VmInterfaceManager
..
Patch Set 8: No score
--
To view, visit http://gerrit.ovirt.org/9770
To unsubscribe, visit http://gerr
Mike Kolesnik has posted comments on this change.
Change subject: core : add NetwrokLinking support to VmInterfaceManager
..
Patch Set 8: Looks good to me, approved
(1 inline comment)
..
Ori Liel has posted comments on this change.
Change subject: cli: update prompt status upon "Connection failure" #880559
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Ori Liel has posted comments on this change.
Change subject: cli: support fetching new sdk proxy
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10027
To unsubscribe, vi
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 19: (10 inline comments)
File backend/manager/dbscripts/upgrade/
Maor Lipchuk has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
..
Patch Set 21: (3 inline comments)
Please fix compilation error and update of VM and template.
.
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2896/
Build Number: 2896
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,632
-
Changes Sin
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: ax_ln_sr.m4: remove debug code
..
build: ax_ln_sr.m4: remove debug code
Change-Id: I1b00b1155d1602eb1c94b4849dbe39d53bb34b3a
Signed-off-by: Alon B
Alon Bar-Lev has posted comments on this change.
Change subject: build: ax_ln_sr.m4: remove debug code
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10119
To unsubscribe, visit h
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: ax_ln_sr.m4: remove debug code
..
build: ax_ln_sr.m4: remove debug code
Change-Id: If5e1d6b42ecc0e2140654c3c35be983ea1b4a727
Signed-off-by: Alon B
Alon Bar-Lev has posted comments on this change.
Change subject: build: ax_ln_sr.m4: remove debug code
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10118
To unsubscribe, visit h
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: ax_ln_sr.m4: remove debug code
..
build: ax_ln_sr.m4: remove debug code
Change-Id: I1b00b1155d1602eb1c94b4849dbe39d53bb34b3a
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: ax_ln_sr.m4: remove debug code
..
build: ax_ln_sr.m4: remove debug code
Change-Id: If5e1d6b42ecc0e2140654c3c35be983ea1b4a727
Signed-off-by: Alon Bar-Lev
Liron Aravot has uploaded a new change for review.
Change subject: core: ReconstructMasterDomain -connect/disconnect hosts
simultaneously
..
core: ReconstructMasterDomain -connect/disconnect hosts simultaneously
When running Re
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: fix broken chalanger test
..
restapi: fix broken chalanger test
Change-Id: Ifaf8e16897468ab6d0ce3567daf7c5297e9b2f06
Signed-off-by: Michael
Michael Pasternak has posted comments on this change.
Change subject: restapi: fix broken chalanger test
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10116
To unsubscribe, visit
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: fix broken chalanger test
..
restapi: fix broken chalanger test
Change-Id: Ifaf8e16897468ab6d0ce3567daf7c5297e9b2f06
Signed-off-by: Michael Pastern
Mike Kolesnik has posted comments on this change.
Change subject: core: create UpdateVmInterfaceVDSCommand
..
Patch Set 11: (6 inline comments)
File
backend/manager/modules/
Ori Liel has posted comments on this change.
Change subject: cli: Wrong name of section in .rhevmshell causes to traceback
#880641
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Mike Kolesnik has posted comments on this change.
Change subject: core: adding VdsmError for failure on VmUpdateDevice on Vnic.
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9668
To unsub
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding host bios fields to vdsStatic table
..
Adding host bios fields to vdsStatic table
adding 6 new vars to vdsStatic
Feature wiki page:
http://wiki.ovirt.o
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding HostSubTab to UI for BIOS information
..
Adding HostSubTab to UI for BIOS information
BIOS information tab is shown under host's subtab as described in
Arik Hadas has posted comments on this change.
Change subject: core: Refactor MigrateVmCommand#getAuditLogTypeValue
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10113
To unsubscribe, visit http://gerrit.ov
1 - 100 of 219 matches
Mail list logo
