Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(4).
......................................................................
core:StorageHelper Cleanup, method name standard(4).
Change method name RunConnectionStorageToDomain to be
compatible with the java standards.
Change-Id: Ib8ea0520193945f787efce96714c70428d6e2630
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
4 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/10128/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
index 1b7fffc..ca5123b 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
@@ -23,7 +23,7 @@
public abstract class BaseFsStorageHelper extends StorageHelperBase {
@Override
- protected boolean RunConnectionStorageToDomain(storage_domains
storageDomain, Guid vdsId, int type) {
+ protected boolean runConnectionStorageToDomain(storage_domains
storageDomain, Guid vdsId, int type) {
boolean returnValue = false;
storage_server_connections connection =
DbFacade.getInstance().getStorageServerConnectionDao().get(
storageDomain.getstorage());
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
index 6371cff..14d1180 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
@@ -16,7 +16,7 @@
}
@Override
- protected boolean RunConnectionStorageToDomain(storage_domains
storageDomain, Guid vdsId, int type) {
+ protected boolean runConnectionStorageToDomain(storage_domains
storageDomain, Guid vdsId, int type) {
return true;
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
index 2cf1421..cf92795 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
@@ -29,7 +29,7 @@
protected static final Log log =
LogFactory.getLog(ISCSIStorageHelper.class);
@Override
- protected boolean RunConnectionStorageToDomain(storage_domains
storageDomain, Guid vdsId, int type) {
+ protected boolean runConnectionStorageToDomain(storage_domains
storageDomain, Guid vdsId, int type) {
return RunConnectionStorageToDomain(storageDomain, vdsId, type, null,
Guid.Empty);
}
@@ -213,12 +213,12 @@
@Override
public boolean ConnectStorageToDomainByVdsId(storage_domains
storageDomain, Guid vdsId) {
- return RunConnectionStorageToDomain(storageDomain, vdsId,
VDSCommandType.ConnectStorageServer.getValue());
+ return runConnectionStorageToDomain(storageDomain, vdsId,
VDSCommandType.ConnectStorageServer.getValue());
}
@Override
public boolean DisconnectStorageFromDomainByVdsId(storage_domains
storageDomain, Guid vdsId) {
- return RunConnectionStorageToDomain(storageDomain, vdsId,
VDSCommandType.DisconnectStorageServer.getValue());
+ return runConnectionStorageToDomain(storageDomain, vdsId,
VDSCommandType.DisconnectStorageServer.getValue());
}
@Override
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
index 04b6b4e..256ee40 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
@@ -33,7 +33,7 @@
Guid vdsId = pool.getspm_vds_id() != null ?
pool.getspm_vds_id().getValue() : Guid.Empty;
if (!vdsId.equals(Guid.Empty)) {
- returnValue = RunConnectionStorageToDomain(storageDomain, vdsId,
type);
+ returnValue = runConnectionStorageToDomain(storageDomain, vdsId,
type);
}
return returnValue;
}
@@ -44,7 +44,7 @@
VdcActionType.RemoveStorageServerConnection.getValue());
}
- protected abstract boolean RunConnectionStorageToDomain(storage_domains
storageDomain, Guid vdsId, int type);
+ protected abstract boolean runConnectionStorageToDomain(storage_domains
storageDomain, Guid vdsId, int type);
protected boolean RunConnectionStorageToDomain(storage_domains
storageDomain, Guid vdsId, int type, LUNs lun, Guid storagePoolId) {
return true;
@@ -52,12 +52,12 @@
@Override
public boolean ConnectStorageToDomainByVdsId(storage_domains
storageDomain, Guid vdsId) {
- return RunConnectionStorageToDomain(storageDomain, vdsId,
VdcActionType.ConnectStorageToVds.getValue());
+ return runConnectionStorageToDomain(storageDomain, vdsId,
VdcActionType.ConnectStorageToVds.getValue());
}
@Override
public boolean DisconnectStorageFromDomainByVdsId(storage_domains
storageDomain, Guid vdsId) {
- return RunConnectionStorageToDomain(storageDomain, vdsId,
+ return runConnectionStorageToDomain(storageDomain, vdsId,
VdcActionType.RemoveStorageServerConnection.getValue());
}
--
To view, visit http://gerrit.ovirt.org/10128
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8ea0520193945f787efce96714c70428d6e2630
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
