Maor Lipchuk has uploaded a new change for review.

Change subject: core:StorageHelper Cleanup, method name standard(2).
......................................................................

core:StorageHelper Cleanup, method name standard(2).

Change method name DisconnectStorageFromDomainByStoragePoolId to be
compatible with the java standards.

Change-Id: I3e071ca8e31e820ae327728630c94fedcec57e44
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
4 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/10125/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
index 6d9bde1..6371cff 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
@@ -11,7 +11,7 @@
     }
 
     @Override
-    public boolean DisconnectStorageFromDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId) {
+    public boolean disconnectStorageFromDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId) {
         return true;
     }
 
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
index 79bee04..138529a 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
@@ -206,7 +206,7 @@
     }
 
     @Override
-    public boolean DisconnectStorageFromDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId) {
+    public boolean disconnectStorageFromDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId) {
         return RunForSingleConnectionInHost(storageDomain, storagePoolId,
                 VDSCommandType.DisconnectStorageServer.getValue());
     }
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
index 4ddd32c..8eddcc3 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
@@ -13,7 +13,7 @@
 public interface IStorageHelper {
     boolean connectStorageToDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId);
 
-    boolean DisconnectStorageFromDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId);
+    boolean disconnectStorageFromDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId);
 
     boolean ConnectStorageToDomainByVdsId(storage_domains storageDomain, Guid 
vdsId);
 
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
index cd6db4b..2f8c905 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
@@ -41,7 +41,7 @@
     }
 
     @Override
-    public boolean DisconnectStorageFromDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId) {
+    public boolean disconnectStorageFromDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId) {
         return RunForSingleConnectionInHost(storageDomain, storagePoolId,
                 VdcActionType.RemoveStorageServerConnection.getValue());
     }


--
To view, visit http://gerrit.ovirt.org/10125
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e071ca8e31e820ae327728630c94fedcec57e44
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to