Maor Lipchuk has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
......................................................................
Patch Set 21: (3 inline comments)
Please fix compilation error and update of VM and template.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java
Line 177:
Line 178: }
Line 179:
Line 180: @Override
Line 181: protected void incrementDbGeneration() {
I would consider to relinquish the method here, since it only called once, and
you can simply call getVmStaticDAO().incrementDbGeneration(getVm().getId())
instead one line method
Line 182: getVmStaticDAO().incrementDbGeneration(getVm().getId());
Line 183: }
Line 184:
Line 185: @Override
Line 200: }
Line 201: }
Line 202:
Line 203: protected void endMoveVmCommand() {
Line 204: incrementDbGeeneration();
Compilation error
/s/incrementDbGeeneration/incrementDbGeneration
Line 205: endActionOnAllImageGroups();
Line 206:
Line 207: if (getVm() != null) {
Line 208: VmHandler.UnLockVm(getVm());
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 79: "auto_startup",
Line 80: "dedicated_vm_for_vds", "default_display_type",
"priority", "default_boot_sequence", "initrd_url",
Line 81: "kernel_url", "kernel_params", "migrationSupport",
"minAllocatedMem", "quotaId", "quotaName",
Line 82: "quotaEnforcementType", "cpuPinning",
Line 83: "vmPayload", "balloonEnabled",
"smartcardEnabled","deleteProtected","db_generation",
/s/db_generation/dbGenereation
What about VmTemplateHandler? Update will not work there either
Line 84: "images", // images list is relational entity - ignore
value changes
Line 85: "interfaces" // interfaces is relational entity -
ignore value changes
Line 86: });
Line 87: mUpdateVmsStatic.AddFields(
--
To view, visit http://gerrit.ovirt.org/9340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedebceb9809dc0b11c0bbe8a2d4af63b0d848df1
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
