Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper cleanup, code clean
......................................................................
core:StorageHelper cleanup, code clean
Refactor implementation of runForSingleConnectionInHost to be more short
and readable
Change-Id: Ica461c6d592932a061472bf87e47e6bfa0687e3d
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
1 file changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/40/10140/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
index 75ff434..d625ab4 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
@@ -32,14 +32,13 @@
}
public boolean runForSingleConnectionInHost(storage_domains storageDomain,
Guid storagePoolId, int type) {
- boolean returnValue = false;
storage_pool pool =
DbFacade.getInstance().getStoragePoolDao().get(storagePoolId);
- Guid vdsId = pool.getspm_vds_id() != null ?
pool.getspm_vds_id().getValue() : Guid.Empty;
-
- if (!vdsId.equals(Guid.Empty)) {
- returnValue = runConnectionStorageToDomain(storageDomain, vdsId,
type);
+ if (pool.getspm_vds_id() != null) {
+ return runConnectionStorageToDomain(storageDomain,
pool.getspm_vds_id().getValue(), type);
+ } else {
+ log.errorFormat("Pool {0} does not have spm vds id to connect
storage to domain.", pool.getname());
+ return false;
}
- return returnValue;
}
@Override
--
To view, visit http://gerrit.ovirt.org/10140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica461c6d592932a061472bf87e47e6bfa0687e3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
