Allon Mureinik has uploaded a new change for review.
Change subject: core: ValidationResult private default constructor
......................................................................
core: ValidationResult private default constructor
ValidationResult's default constructor should be private (according to
its javadoc), and valid results should be referenced via the constant
ValidationResult.VALID. Most occurrences in the code adhere to this
rule, except for a single occurrence in AddDiskToVmCommandTest.
This patch returns the default constructor to its intended private state
and fixes the faulty usage in AddDiskToVmCommandTest.
Change-Id: I7afa82aa1ec489b52da78b97b91c2a48eefb8b5f
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/10142/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
index 227ba0c..4dafd93 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
@@ -23,7 +23,7 @@
* Default validation result is success with no message.
* This constructor is private, it is only used to create a 'valid'
result. Please use {@link ValidationResult#VALID}
*/
- public ValidationResult() {
+ private ValidationResult() {
message = null;
}
diff --git
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
index 0dc3807..c55f135 100644
---
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
+++
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
@@ -409,7 +409,7 @@
private SnapshotsValidator mockSnapshotValidator() {
SnapshotsValidator snapshotsValidator = mock(SnapshotsValidator.class);
-
when(snapshotsValidator.vmNotDuringSnapshot(any(Guid.class))).thenReturn(new
ValidationResult());
+
when(snapshotsValidator.vmNotDuringSnapshot(any(Guid.class))).thenReturn(ValidationResult.VALID);
return snapshotsValidator;
}
--
To view, visit http://gerrit.ovirt.org/10142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7afa82aa1ec489b52da78b97b91c2a48eefb8b5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
