Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(11).
......................................................................
core:StorageHelper Cleanup, method name standard(11).
Change method name getStorageServerConnectionsByDoman to be
compatible with the java standards.
Change-Id: I94209f664b8c9463659b7ddc1d37b1fa8f9c70de
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
5 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/10136/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
index 700ea8c..f288ed0 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
@@ -69,7 +69,7 @@
}
@Override
- public List<storage_server_connections>
GetStorageServerConnectionsByDomain(
+ public List<storage_server_connections>
getStorageServerConnectionsByDomain(
storage_domain_static storageDomain) {
return new ArrayList<storage_server_connections>(
Arrays.asList(new storage_server_connections[] {
DbFacade.getInstance()
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java
index 2b2086c..9e74d57 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java
@@ -79,7 +79,7 @@
Set<storage_server_connections> isoConnections =
new HashSet<storage_server_connections>(
StorageHelperDirector.getInstance().getItem(getIsoType())
-
.GetStorageServerConnectionsByDomain(isoDomains.get(0).getStorageStaticData()));
+
.getStorageServerConnectionsByDomain(isoDomains.get(0).getStorageStaticData()));
if (_isoType != getStoragePool().getstorage_pool_type()) {
connections.removeAll(isoConnections);
} else {
@@ -93,7 +93,7 @@
Set<storage_server_connections> exportConnections =
new HashSet<storage_server_connections>(
StorageHelperDirector.getInstance().getItem(getExportType())
-
.GetStorageServerConnectionsByDomain(exportDomains.get(0).getStorageStaticData()));
+
.getStorageServerConnectionsByDomain(exportDomains.get(0).getStorageStaticData()));
if (_exportType != getStoragePool().getstorage_pool_type()) {
connections.removeAll(exportConnections);
} else {
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
index 7c83e9b..71efcc7 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
@@ -233,7 +233,7 @@
}
@Override
- public List<storage_server_connections>
GetStorageServerConnectionsByDomain(
+ public List<storage_server_connections>
getStorageServerConnectionsByDomain(
storage_domain_static storageDomain) {
return
DbFacade.getInstance().getStorageServerConnectionDao().getAllForVolumeGroup(storageDomain.getstorage());
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
index 75cc867..d1d2496 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
@@ -30,7 +30,7 @@
boolean validateStoragePoolConnectionsInHost(VDS vds,
List<storage_server_connections> connections,
Guid storagePoolId);
- List<storage_server_connections> GetStorageServerConnectionsByDomain(
+ List<storage_server_connections> getStorageServerConnectionsByDomain(
storage_domain_static storageDomain);
boolean IsConnectSucceeded(Map<String, String> returnValue,
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
index 0971876..3f01f75 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
@@ -101,7 +101,7 @@
}
@Override
- public List<storage_server_connections>
GetStorageServerConnectionsByDomain(
+ public List<storage_server_connections>
getStorageServerConnectionsByDomain(
storage_domain_static storageDomain) {
return new java.util.ArrayList<storage_server_connections>();
}
--
To view, visit http://gerrit.ovirt.org/10136
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94209f664b8c9463659b7ddc1d37b1fa8f9c70de
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
