Maor Lipchuk has uploaded a new change for review.
Change subject: core:StorageHelper Cleanup, method name standard(8).
......................................................................
core:StorageHelper Cleanup, method name standard(8).
Change method name connectStorageToLunByVdsId to be
compatible with the java standards.
Change-Id: I615c5bb58adc969ca16f83be19b37a4e6dccd40c
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
6 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/10133/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
index 7cbfe44..1ff1caf 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
@@ -55,7 +55,7 @@
updateLUNConnectionsInfo(lun);
if (!StorageHelperDirector.getInstance()
.getItem(getLUNStorageType(lun))
- .ConnectStorageToLunByVdsId(null,
+ .connectStorageToLunByVdsId(null,
getVm().getRunOnVds().getValue(),
lun,
getVm().getStoragePoolId())) {
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
index c320d6f..fe950a6 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
@@ -357,7 +357,7 @@
if (!lun.getLunConnections().isEmpty()
&&
!StorageHelperDirector.getInstance().getItem(lun.getLunConnections().get(0).getstorage_type())
- .ConnectStorageToLunByVdsId(null, hostId, lun,
getVm().getStoragePoolId())) {
+ .connectStorageToLunByVdsId(null, hostId, lun,
getVm().getStoragePoolId())) {
log.infoFormat("Failed to connect a lun disk to vdsm {0}
skiping it", hostId);
return false;
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
index 20669c4..09f11d9 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
@@ -150,7 +150,7 @@
try {
return StorageHelperDirector.getInstance()
.getItem(getStorageDomain().getstorage_type())
- .ConnectStorageToLunByVdsId(getStorageDomain(),
vds.getId(), lun, Guid.Empty);
+ .connectStorageToLunByVdsId(getStorageDomain(),
vds.getId(), lun, Guid.Empty);
} catch (VdcBLLException e) {
final ConnectAllHostsToLunCommandReturnValue result = getResult();
result.setFailedVds(vds);
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
index 785a58f..a2d1873 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
@@ -222,7 +222,7 @@
}
@Override
- public boolean ConnectStorageToLunByVdsId(storage_domains storageDomain,
Guid vdsId, LUNs lun, Guid storagePoolId) {
+ public boolean connectStorageToLunByVdsId(storage_domains storageDomain,
Guid vdsId, LUNs lun, Guid storagePoolId) {
return runConnectionStorageToDomain(storageDomain, vdsId,
VDSCommandType.ConnectStorageServer.getValue(), lun, storagePoolId);
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
index 6ff4fb6..5a1d0f2 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
@@ -19,7 +19,7 @@
boolean disconnectStorageFromDomainByVdsId(storage_domains storageDomain,
Guid vdsId);
- boolean ConnectStorageToLunByVdsId(storage_domains storageDomain, Guid
vdsId, LUNs lun, Guid storagePoolId);
+ boolean connectStorageToLunByVdsId(storage_domains storageDomain, Guid
vdsId, LUNs lun, Guid storagePoolId);
boolean disconnectStorageFromLunByVdsId(storage_domains storageDomain,
Guid vdsId, LUNs lun);
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
index ca0a9de..f3dd4c1 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
@@ -62,7 +62,7 @@
}
@Override
- public boolean ConnectStorageToLunByVdsId(storage_domains storageDomain,
Guid vdsId, LUNs lun, Guid storagePoolId) {
+ public boolean connectStorageToLunByVdsId(storage_domains storageDomain,
Guid vdsId, LUNs lun, Guid storagePoolId) {
return runConnectionStorageToDomain(storageDomain, vdsId,
VdcActionType.ConnectStorageToVds.getValue(), lun, storagePoolId);
}
--
To view, visit http://gerrit.ovirt.org/10133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I615c5bb58adc969ca16f83be19b37a4e6dccd40c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
