Maor Lipchuk has uploaded a new change for review.

Change subject: core:StorageHelper Cleanup, method name standard(7).
......................................................................

core:StorageHelper Cleanup, method name standard(7).

Change method name disconnectStorageFromLunByVdsId to be
compatible with the java standards.

Change-Id: I022232d2b0f4475e7d25393a45a6571d3a35456e
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
4 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/10132/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
index a0c9ce8..20669c4 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
@@ -103,7 +103,7 @@
                 for (Guid vdsId : processed.get(lunId)) {
                     LUNs lun = lunsMap.get(lunId);
                     
StorageHelperDirector.getInstance().getItem(getStoragePool().getstorage_pool_type())
-                            
.DisconnectStorageFromLunByVdsId(getStorageDomain(), vdsId, lun);
+                            
.disconnectStorageFromLunByVdsId(getStorageDomain(), vdsId, lun);
                 }
             }
         }
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
index 96ef1c1..785a58f 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
@@ -227,7 +227,7 @@
     }
 
     @Override
-    public boolean DisconnectStorageFromLunByVdsId(storage_domains 
storageDomain, Guid vdsId, LUNs lun) {
+    public boolean disconnectStorageFromLunByVdsId(storage_domains 
storageDomain, Guid vdsId, LUNs lun) {
         return runConnectionStorageToDomain(storageDomain, vdsId, 
VDSCommandType.DisconnectStorageServer.getValue(),
                 lun, Guid.Empty);
     }
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
index eb7aa3d..6ff4fb6 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
@@ -21,7 +21,7 @@
 
     boolean ConnectStorageToLunByVdsId(storage_domains storageDomain, Guid 
vdsId, LUNs lun, Guid storagePoolId);
 
-    boolean DisconnectStorageFromLunByVdsId(storage_domains storageDomain, 
Guid vdsId, LUNs lun);
+    boolean disconnectStorageFromLunByVdsId(storage_domains storageDomain, 
Guid vdsId, LUNs lun);
 
     boolean StorageDomainRemoved(storage_domain_static storageDomain);
 
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
index e263704..ca0a9de 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
@@ -67,7 +67,7 @@
     }
 
     @Override
-    public boolean DisconnectStorageFromLunByVdsId(storage_domains 
storageDomain, Guid vdsId, LUNs lun) {
+    public boolean disconnectStorageFromLunByVdsId(storage_domains 
storageDomain, Guid vdsId, LUNs lun) {
         return runConnectionStorageToDomain(storageDomain, vdsId,
                 VdcActionType.RemoveStorageServerConnection.getValue(), lun, 
Guid.Empty);
     }


--
To view, visit http://gerrit.ovirt.org/10132
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I022232d2b0f4475e7d25393a45a6571d3a35456e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to