Mike Kolesnik has posted comments on this change.
Change subject: core : add NetwrokLinking support to VmInterfaceManager
......................................................................
Patch Set 8: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
Line 93: * @return
Line 94: */
Line 95: public boolean isValidVmNetwork(VmNetworkInterface iface,
Map<String, Network> networksByName) {
Line 96: String networkName = iface.getNetworkName();
Line 97: if (networkName == null) {
I don't think this logically belongs here, since if there's no network how can
you test if it's VM network or not?
Instead, the caller should not send null network name
Line 98: return true;
Line 99: }
Line 100: return (networksByName.containsKey(networkName) &&
networksByName.get(networkName).isVmNetwork());
Line 101: }
--
To view, visit http://gerrit.ovirt.org/9770
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16ef011a47efc6265787b845dc7af6fee5044578
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
