Maor Lipchuk has uploaded a new change for review.

Change subject: core:StorageHelper cleanup,Remove unused method.
......................................................................

core:StorageHelper cleanup,Remove unused method.

Remove unused method.

Change-Id: Ibeb4d32a82c78b4a2699065601e6df20e886f786
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
1 file changed, 0 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/10126/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
index 2f8c905..f7d57c3 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
@@ -6,10 +6,8 @@
 
 import org.ovirt.engine.core.bll.Backend;
 import org.ovirt.engine.core.common.AuditLogType;
-import 
org.ovirt.engine.core.common.action.StorageServerConnectionParametersBase;
 import org.ovirt.engine.core.common.action.VdcActionType;
 import org.ovirt.engine.core.common.businessentities.LUNs;
-import org.ovirt.engine.core.common.businessentities.StoragePoolStatus;
 import org.ovirt.engine.core.common.businessentities.VDS;
 import org.ovirt.engine.core.common.businessentities.storage_domain_static;
 import org.ovirt.engine.core.common.businessentities.storage_domains;
@@ -44,18 +42,6 @@
     public boolean disconnectStorageFromDomainByStoragePoolId(storage_domains 
storageDomain, Guid storagePoolId) {
         return RunForSingleConnectionInHost(storageDomain, storagePoolId,
                 VdcActionType.RemoveStorageServerConnection.getValue());
-    }
-
-    protected void RunForAllConnectionsInPool(VdcActionType type, VDS vds) {
-        storage_pool pool = 
DbFacade.getInstance().getStoragePoolDao().get(vds.getStoragePoolId());
-        if (pool.getstatus() != StoragePoolStatus.Uninitialized) {
-            List<storage_server_connections> connections = 
DbFacade.getInstance()
-                    
.getStorageServerConnectionDao().getAllForStoragePool(vds.getStoragePoolId());
-            for (storage_server_connections connection : connections) {
-                Backend.getInstance().runInternalAction(type,
-                        new StorageServerConnectionParametersBase(connection, 
vds.getId()));
-            }
-        }
     }
 
     protected abstract boolean RunConnectionStorageToDomain(storage_domains 
storageDomain, Guid vdsId, int type);


--
To view, visit http://gerrit.ovirt.org/10126
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibeb4d32a82c78b4a2699065601e6df20e886f786
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to