Re: [PR] Upgrade Calcite to 1.39.0 [pinot]

2025-03-18 Thread via GitHub
yashmayya commented on code in PR #15263: URL: https://github.com/apache/pinot/pull/15263#discussion_r2002493528 ## pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeSystem.java: ## @@ -62,16 +62,36 @@ public boolean shouldConvertRaggedUnionTypesToVarying() {

Re: [PR] Fix array agg functions to use existing result holder when present [pinot]

2025-03-18 Thread via GitHub
codecov-commenter commented on PR #15308: URL: https://github.com/apache/pinot/pull/15308#issuecomment-2735471533 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15308?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fix array agg functions to use existing result holder when present [pinot]

2025-03-18 Thread via GitHub
yashmayya opened a new pull request, #15308: URL: https://github.com/apache/pinot/pull/15308 - Fixes https://github.com/apache/pinot/issues/15238 - If these aggregation functions are currently used when there are multiple blocks per segment, they'll return an incorrect value because they'

(pinot) branch master updated: Render new UI options for rebalance server operation (#15256)

2025-03-18 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a94380a492 Render new UI options for rebalance

Re: [PR] [feature] render new options for rebalance server [pinot]

2025-03-18 Thread via GitHub
yashmayya merged PR #15256: URL: https://github.com/apache/pinot/pull/15256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] [feature] render new options for rebalance server [pinot]

2025-03-18 Thread via GitHub
himanish-star commented on code in PR #15256: URL: https://github.com/apache/pinot/pull/15256#discussion_r2002387752 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionInteger.ts

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002274863 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1093,6 +1093,35 @@ public void segmentSto

Re: [I] Pauseless Consumption [pinot]

2025-03-18 Thread via GitHub
9aman commented on issue #10147: URL: https://github.com/apache/pinot/issues/10147#issuecomment-2735267653 Attaching the relevant docs and PR's for the issue: Doc: https://docs.google.com/document/d/1d-xttk7sXFIOqfyZvYw5W_KeGS6Ztmi8eYevBcCrT_c/edit?tab=t.0 https://docs.google.

[PR] Clean up usage of couple of APIs of Tracing ThreadResourceAccountant [pinot]

2025-03-18 Thread via GitHub
vrajat opened a new pull request, #15303: URL: https://github.com/apache/pinot/pull/15303 This PR has a couple of minor cleanups of how Tracing methods are used. 1. Use `Tracing.ThreadAccountantOps.clear` 2. External modules do not need to create a `ThreadUsageProvider` For 1., t

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002278498 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1093,6 +1093,35 @@ public void segmentSto

Re: [I] Inconsistent results given by array_agg vs group_by [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on issue #15238: URL: https://github.com/apache/pinot/issues/15238#issuecomment-2735042117 Find the issue. `aggregate()` is not correctly reading the previous result from the result holder. cc @xiangfu0 -- This is an automated message from the Apache Git Service. T

Re: [PR] Close `ChunkReaderContext` to improve projection/scan based filter memory for raw columns [pinot]

2025-03-18 Thread via GitHub
itschrispeck commented on code in PR #15139: URL: https://github.com/apache/pinot/pull/15139#discussion_r2002314552 ## pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java: ## @@ -594,4 +594,17 @@ public void close() } } } + + /** + * Close th

Re: [PR] Close `ChunkReaderContext` to improve projection/scan based filter memory for raw columns [pinot]

2025-03-18 Thread via GitHub
itschrispeck commented on code in PR #15139: URL: https://github.com/apache/pinot/pull/15139#discussion_r2002313422 ## pinot-core/src/main/java/org/apache/pinot/core/plan/ProjectPlanNode.java: ## @@ -80,9 +80,10 @@ public BaseProjectOperator run() { DocIdSetOperator docIdSe

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002258351 ## pinot-common/src/main/java/org/apache/pinot/common/protocols/SegmentCompletionProtocol.java: ## @@ -123,6 +123,7 @@ public enum ControllerResponseStatus { public

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002285709 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1093,6 +1093,35 @@ public void seg

Re: [PR] Implement ordering in segment state transitions [pinot]

2025-03-18 Thread via GitHub
noob-se7en commented on PR #15261: URL: https://github.com/apache/pinot/pull/15261#issuecomment-2734838977 @Jackie-Jiang this PR is not in ready state as of now. We want to rely on sequence number instead of segmentZkMetadata for previous segment. -- This is an automated message from the

[PR] Add more StartMinionCommand -config alias [pinot]

2025-03-18 Thread via GitHub
xiangfu0 opened a new pull request, #15307: URL: https://github.com/apache/pinot/pull/15307 Add more StartMinionCommand -config alias: "-configFileName", "-config", "-configFile", "-minionConfig", "-minionConf" -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002251422 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1210,6 +1222,19 @@ boolean commitSegment(String control

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002250414 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -267,6 +267,7 @@ public void deleteSegmentFile()

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002206416 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java: ## @@ -297,6 +297,28 @@ public String segmentCom

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002244114 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -267,6 +267,7 @@ public void deleteSegmentFile() { pr

Re: [PR] Enhance rebalance progress stats [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on PR #15266: URL: https://github.com/apache/pinot/pull/15266#issuecomment-2735075640 Why is the json fields prefixed with `'_'`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002206416 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java: ## @@ -297,6 +297,28 @@ public String segmentCom

Re: [I] Inconsistent results given by array_agg vs group_by [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on issue #15238: URL: https://github.com/apache/pinot/issues/15238#issuecomment-2735031868 @gortiz @yashmayya Can you help take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
lnbest0707-uber commented on PR #15234: URL: https://github.com/apache/pinot/pull/15234#issuecomment-2735020908 > This won't work for pauseless consumption because segment build happens after commit. cc @KKcorps @9aman > > Ideally we should try to follow the mechanism introduced in #1

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002191472 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java: ## @@ -297,6 +297,28 @@ public String segmentCommit

Re: [I] Time Pruner should support queries where we're operating on the time column itself [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang closed issue #14362: Time Pruner should support queries where we're operating on the time column itself URL: https://github.com/apache/pinot/issues/14362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

(pinot) branch master updated: add metric for multstiage num groups limit reached (#15221)

2025-03-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 315059e844 add metric for multstiage num groups l

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002157712 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java: ## @@ -1386,6 +1393,28 @@ public void

Re: [PR] add metric for multstiage num groups limit reached [pinot]

2025-03-18 Thread via GitHub
jadami10 commented on PR #15221: URL: https://github.com/apache/pinot/pull/15221#issuecomment-2734948567 sorry jackie, lost track of this. ty for pushing it through -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002155543 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java: ## @@ -1386,6 +1393,28 @@ public void testGe

Re: [PR] Add more StartMinionCommand -config alias [pinot]

2025-03-18 Thread via GitHub
codecov-commenter commented on PR #15307: URL: https://github.com/apache/pinot/pull/15307#issuecomment-2734931984 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15307?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Retry on segment cannot build [pinot]

2025-03-18 Thread via GitHub
chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002152540 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/BlockingSegmentCompletionFSM.java: ## @@ -181,6 +181,21 @@ public boolean isDone() {

Re: [PR] Upgrade Calcite to 1.39.0 [pinot]

2025-03-18 Thread via GitHub
yashmayya commented on code in PR #15263: URL: https://github.com/apache/pinot/pull/15263#discussion_r2000358188 ## pinot-query-planner/src/test/resources/queries/JoinPlans.json: ## @@ -405,10 +405,10 @@ "\nLogicalProject(col1=[$0])", "\n LogicalJoin(condi

Re: [PR] feat(KafkaConfluentSchemaRegistryJsonMessageDecoder): added the JSON confluent schema decoder [pinot]

2025-03-18 Thread via GitHub
r-reis commented on code in PR #15273: URL: https://github.com/apache/pinot/pull/15273#discussion_r2002119762 ## pinot-plugins/pinot-input-format/pinot-confluent-json/src/main/java/org/apache/pinot/plugin/inputformat/json/confluent/KafkaConfluentSchemaRegistryJsonMessageDecoder.java: ##

(pinot) branch master updated (ac9945dfe9 -> 8997f3a926)

2025-03-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ac9945dfe9 increase test waiting time for MSE (#15229) add 8997f3a926 Enable force overwrite for partial upserts (

(pinot) branch master updated (4b2ee96b40 -> c675b99a43)

2025-03-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 4b2ee96b40 Clean up usage of couple of APIs of Tracing ThreadResourceAccountant (#15303) add c675b99a43 Support

Re: [PR] feat(KafkaConfluentSchemaRegistryJsonMessageDecoder): added the JSON confluent schema decoder [pinot]

2025-03-18 Thread via GitHub
r-reis commented on code in PR #15273: URL: https://github.com/apache/pinot/pull/15273#discussion_r2002118563 ## pom.xml: ## @@ -1929,6 +1939,11 @@ kotlin-reflect ${kotlin.stdlib.version} + Review Comment: It was a leftover from a previous tes

Re: [PR] feat(KafkaConfluentSchemaRegistryJsonMessageDecoder): added the JSON confluent schema decoder [pinot]

2025-03-18 Thread via GitHub
r-reis commented on code in PR #15273: URL: https://github.com/apache/pinot/pull/15273#discussion_r2002118175 ## pinot-plugins/pinot-input-format/pinot-confluent-json/src/main/java/org/apache/pinot/plugin/inputformat/json/confluent/KafkaConfluentSchemaRegistryJsonMessageDecoder.java: ##

(pinot) branch master updated (8997f3a926 -> 4b2ee96b40)

2025-03-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 8997f3a926 Enable force overwrite for partial upserts (#15107) add 4b2ee96b40 Clean up usage of couple of APIs of

Re: [PR] Add `DATE_TRUNC` Optimizer [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang merged PR #14385: URL: https://github.com/apache/pinot/pull/14385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Allows consumption during build for Dedup [pinot]

2025-03-18 Thread via GitHub
noob-se7en commented on PR #15296: URL: https://github.com/apache/pinot/pull/15296#issuecomment-2734846993 For Pauseless there as edge case - consider case where server OOMs after releasing semaphore. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Implement ordering in segment state transitions [pinot]

2025-03-18 Thread via GitHub
noob-se7en commented on PR #15261: URL: https://github.com/apache/pinot/pull/15261#issuecomment-2734850456 The problem you mentioned is fixed in this PR: https://github.com/apache/pinot/pull/15246 This PR needs to merge above. -- This is an automated message from the Apache Git Service

Re: [PR] Upgrade AWS SDK to 2.30; update tests to disable default integrity protection [pinot]

2025-03-18 Thread via GitHub
xiangfu0 commented on PR #14909: URL: https://github.com/apache/pinot/pull/14909#issuecomment-2734846895 Updated the defaults. I think for AWS S3 this upgrade is fine. However for other s3 distribution, this upgrade may break it. -- This is an automated message from the Apache Gi

[PR] Support requestChecksumCalculationWhenRequired and responseChecksumValidationWhenRequired in S3Config [pinot]

2025-03-18 Thread via GitHub
xiangfu0 opened a new pull request, #15304: URL: https://github.com/apache/pinot/pull/15304 Support 2 configs in S3PinotFs: - `requestChecksumCalculation`: default to `WHEN_SUPPORTED`, can be configured to `WHEN_REQUIRED` - `responseChecksumValidation`: default to `WHEN_SUPPORTED`, can

Re: [PR] Enable force overwrite for partial upserts [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang merged PR #15107: URL: https://github.com/apache/pinot/pull/15107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [S3 Plugin]Support requestChecksumCalculationWhenRequired and responseChecksumValidationWhenRequired in S3Config [pinot]

2025-03-18 Thread via GitHub
xiangfu0 merged PR #15304: URL: https://github.com/apache/pinot/pull/15304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2002064702 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java: ## @@ -165,6 +187,95 @@ private void manageRetentionForRe

Re: [PR] Clean up usage of couple of APIs of Tracing ThreadResourceAccountant [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang merged PR #15303: URL: https://github.com/apache/pinot/pull/15303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Null handing issue with Partial upserts and partialUpsertStrategies [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang closed issue #14924: Null handing issue with Partial upserts and partialUpsertStrategies URL: https://github.com/apache/pinot/issues/14924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Implement ordering in segment state transitions [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on code in PR #15261: URL: https://github.com/apache/pinot/pull/15261#discussion_r2002038117 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -927,6 +927,8 @@ private void createNe

Re: [PR] add metric for multstiage num groups limit reached [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang merged PR #15221: URL: https://github.com/apache/pinot/pull/15221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [feature] render new options for rebalance server [pinot]

2025-03-18 Thread via GitHub
somandal commented on PR #15256: URL: https://github.com/apache/pinot/pull/15256#issuecomment-2733797187 let's also update the latest video in the PR description? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Close `ChunkReaderContext` to improve projection/scan based filter memory for raw columns [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on code in PR #15139: URL: https://github.com/apache/pinot/pull/15139#discussion_r2001839004 ## pinot-core/src/main/java/org/apache/pinot/core/plan/ProjectPlanNode.java: ## @@ -80,9 +80,10 @@ public BaseProjectOperator run() { DocIdSetOperator docIdSe

(pinot) branch master updated (315059e844 -> ac9945dfe9)

2025-03-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 315059e844 add metric for multstiage num groups limit reached (#15221) add ac9945dfe9 increase test waiting time f

Re: [PR] Close `ChunkReaderContext` to improve projection/scan based filter memory for raw columns [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on code in PR #15139: URL: https://github.com/apache/pinot/pull/15139#discussion_r2001833823 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkForwardIndexReaderV4.java: ## @@ -376,7 +375,7 @@ pub

Re: [PR] Close `ChunkReaderContext` to improve projection/scan based filter memory for raw columns [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on code in PR #15139: URL: https://github.com/apache/pinot/pull/15139#discussion_r2001833170 ## pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/ScanBasedDocIdIterator.java: ## @@ -57,9 +57,15 @@ default MutableRoaringBitmap applyAnd(

Re: [PR] Close `ChunkReaderContext` to improve projection/scan based filter memory for raw columns [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on code in PR #15139: URL: https://github.com/apache/pinot/pull/15139#discussion_r2001830694 ## pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java: ## @@ -594,4 +594,17 @@ public void close() } } } + + /** + * Close th

Re: [PR] increase test waiting time for MSE [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang merged PR #15229: URL: https://github.com/apache/pinot/pull/15229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [feature] render new options for rebalance server [pinot]

2025-03-18 Thread via GitHub
codecov-commenter commented on PR #15256: URL: https://github.com/apache/pinot/pull/15256#issuecomment-2734089947 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15256?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Broker list fetching API in PinotConnection is fetching dead servers as well which leads to query failures sometimes (#15187) (#15207)

2025-03-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a970d0671e Broker list fetching API in PinotConne

Re: [PR] Broker list fetching API in PinotConnection is fetching dead servers … [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang merged PR #15207: URL: https://github.com/apache/pinot/pull/15207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Optimize initialization time and memory usage of dimension table [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on code in PR #15130: URL: https://github.com/apache/pinot/pull/15130#discussion_r2001624953 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java: ## @@ -187,43 +221,79 @@ private DimensionTable createFastLo

Re: [PR] Add support for orphan segment cleanup [pinot]

2025-03-18 Thread via GitHub
swaminathanmanish merged PR #15142: URL: https://github.com/apache/pinot/pull/15142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] Update RebalanceResult field order [pinot]

2025-03-18 Thread via GitHub
codecov-commenter commented on PR #15305: URL: https://github.com/apache/pinot/pull/15305#issuecomment-2734071088 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15305?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Add support for orphan segment cleanup (#15142)

2025-03-18 Thread manishswaminathan
This is an automated email from the ASF dual-hosted git repository. manishswaminathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 68260f9870 Add support for orphan segm

Re: [I] [Test] Add query test for LOOKUP join [pinot]

2025-03-18 Thread via GitHub
yashmayya closed issue #15224: [Test] Add query test for LOOKUP join URL: https://github.com/apache/pinot/issues/15224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Add test case for lookup join [pinot]

2025-03-18 Thread via GitHub
yashmayya merged PR #15244: URL: https://github.com/apache/pinot/pull/15244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

(pinot) branch master updated: Add integration test for lookup join in the multi-stage engine (#15244)

2025-03-18 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7ab5a13637 Add integration test for lookup joi

Re: [PR] Support requestChecksumCalculationWhenRequired and responseChecksumValidationWhenRequired in S3Config [pinot]

2025-03-18 Thread via GitHub
codecov-commenter commented on PR #15304: URL: https://github.com/apache/pinot/pull/15304#issuecomment-2733975549 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15304?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [feature] render new options for rebalance server [pinot]

2025-03-18 Thread via GitHub
yashmayya commented on code in PR #15256: URL: https://github.com/apache/pinot/pull/15256#discussion_r2001481701 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionInteger.tsx: #

(pinot) branch master updated (ad5bb408a4 -> ea3f3f4cd3)

2025-03-18 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ad5bb408a4 Fix LOOKUP join (#15223) add ea3f3f4cd3 Bump software.amazon.awssdk:bom from 2.31.1 to 2.31.2 (#15302)

Re: [PR] Clean up usage of couple of APIs of Tracing ThreadResourceAccountant [pinot]

2025-03-18 Thread via GitHub
codecov-commenter commented on PR #15303: URL: https://github.com/apache/pinot/pull/15303#issuecomment-2733546523 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15303?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.1 to 2.31.2 [pinot]

2025-03-18 Thread via GitHub
tibrewalpratik17 merged PR #15302: URL: https://github.com/apache/pinot/pull/15302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.2 deleted (was a3199794c8)

2025-03-18 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was a3199794c8 Bump software.amazon.awssdk:bom from 2.31.1 to 2.31.2 The revi

Re: [PR] Substitute TransferableBlock with MseBlock [pinot]

2025-03-18 Thread via GitHub
gortiz commented on code in PR #15245: URL: https://github.com/apache/pinot/pull/15245#discussion_r1989329010 ## pinot-common/src/main/java/org/apache/pinot/common/datatable/StatMap.java: ## @@ -61,6 +61,13 @@ public StatMap(Class keyClass) { _map = Collections.synchronized

Re: [PR] [feature] render new options for rebalance server [pinot]

2025-03-18 Thread via GitHub
himanish-star commented on code in PR #15256: URL: https://github.com/apache/pinot/pull/15256#discussion_r2001310006 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts: ## @@ -0,0 +1,150 @@ +export type RebalanceSe

Re: [PR] Add support for orphan segment cleanup [pinot]

2025-03-18 Thread via GitHub
9aman commented on code in PR #15142: URL: https://github.com/apache/pinot/pull/15142#discussion_r2001098021 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java: ## @@ -55,6 +55,8 @@ public class SegmentsValidationAndRetentionCo

Re: [PR] Add test case for lookup join [pinot]

2025-03-18 Thread via GitHub
yashmayya commented on code in PR #15244: URL: https://github.com/apache/pinot/pull/15244#discussion_r2000992074 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java: ## @@ -1618,6 +1627,43 @@ public void testNumServers

Re: [PR] Fix LOOKUP join [pinot]

2025-03-18 Thread via GitHub
yashmayya commented on PR #15223: URL: https://github.com/apache/pinot/pull/15223#issuecomment-2733130212 @krishan1390 you can rebase your PR on the latest `master` and I can then merge yours as well, thanks. -- This is an automated message from the Apache Git Service. To respond to the m

(pinot) branch master updated: Fix LOOKUP join (#15223)

2025-03-18 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ad5bb408a4 Fix LOOKUP join (#15223) ad5bb408a4

Re: [PR] Fix LOOKUP join [pinot]

2025-03-18 Thread via GitHub
yashmayya merged PR #15223: URL: https://github.com/apache/pinot/pull/15223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Fix LOOKUP join [pinot]

2025-03-18 Thread via GitHub
krishan1390 commented on PR #15223: URL: https://github.com/apache/pinot/pull/15223#issuecomment-2733105703 @Jackie-Jiang Added a test case for this in https://github.com/apache/pinot/pull/15244 Should we merge that PR to this branch ? Or should I wait for this PR to be merged first

[PR] Bump software.amazon.awssdk:bom from 2.31.1 to 2.31.2 [pinot]

2025-03-18 Thread via GitHub
dependabot[bot] opened a new pull request, #15302: URL: https://github.com/apache/pinot/pull/15302 Bumps software.amazon.awssdk:bom from 2.31.1 to 2.31.2. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- | |

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.2 created (now a3199794c8)

2025-03-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at a3199794c8 Bump software.amazon.awssdk:bom from 2.31.1 to 2.31.2 No n

Re: [PR] Add support for orphan segment cleanup [pinot]

2025-03-18 Thread via GitHub
9aman commented on code in PR #15142: URL: https://github.com/apache/pinot/pull/15142#discussion_r2000894701 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java: ## @@ -55,6 +55,8 @@ public class SegmentsValidationAndRetentionCo

Re: [PR] Add support for orphan segment cleanup [pinot]

2025-03-18 Thread via GitHub
9aman commented on code in PR #15142: URL: https://github.com/apache/pinot/pull/15142#discussion_r2000870263 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java: ## @@ -190,7 +190,11 @@ public enum ControllerGauge implements AbstractMetrics.Gauge

Re: [PR] Query thread context and cid [pinot]

2025-03-18 Thread via GitHub
gortiz merged PR #15180: URL: https://github.com/apache/pinot/pull/15180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [I] Improve error handling and reporting in query side [pinot]

2025-03-18 Thread via GitHub
gortiz commented on issue #14950: URL: https://github.com/apache/pinot/issues/14950#issuecomment-2732004075 Correlation ID PR has been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[I] Unable to change the default storage path in pinot [pinot]

2025-03-18 Thread via GitHub
Aashiqps opened a new issue, #15301: URL: https://github.com/apache/pinot/issues/15301 i have setup pinot in local server, by default the real time data is stored in /tmp directory. i have change the configuration to store the default data storage but it is not working. can you guide to cha