Jackie-Jiang commented on code in PR #15139:
URL: https://github.com/apache/pinot/pull/15139#discussion_r2001839004
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/ProjectPlanNode.java:
##########
@@ -80,9 +80,10 @@ public BaseProjectOperator<?> run() {
DocIdSetOperator docIdSetOperator =
_maxDocsPerCall > 0 ? new DocIdSetPlanNode(_segmentContext,
_queryContext, _maxDocsPerCall,
_filterOperator).run() : null;
- ProjectionOperator projectionOperator =
- ProjectionOperatorUtils.getProjectionOperator(dataSourceMap,
docIdSetOperator);
- return hasNonIdentifierExpression ? new TransformOperator(_queryContext,
projectionOperator, _expressions)
- : projectionOperator;
+ try (ProjectionOperator projectionOperator =
Review Comment:
This doesn't seem correct. Can we close the operator at planning phase?
Shouldn't it be closed after query execution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
