lnbest0707-uber commented on code in PR #15234:
URL: https://github.com/apache/pinot/pull/15234#discussion_r2002206416
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java:
##########
@@ -297,6 +297,28 @@ public String
segmentCommitEndWithMetadata(@QueryParam(SegmentCompletionProtocol
return response;
}
+ @GET
Review Comment:
Some other endpoints in this class, like `segmentCommitStart`, are not read
only but still use `GET` method.
Seems the current convention is that, we only use `POST` when we need to
attach the multi-part metadata.
But I can change to POST if preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
