Jackie-Jiang commented on code in PR #15139:
URL: https://github.com/apache/pinot/pull/15139#discussion_r2001833170
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/ScanBasedDocIdIterator.java:
##########
@@ -57,9 +57,15 @@ default MutableRoaringBitmap applyAnd(ImmutableRoaringBitmap
docIds) {
/**
* Returns the estimated (effective) cardinality of the underlying data
source
*/
-
default float getEstimatedCardinality(boolean isAndDocIdSet) {
//default N/A behavior so that it always get picked in the end
return isAndDocIdSet ? Float.NEGATIVE_INFINITY : Float.POSITIVE_INFINITY;
}
+
+ /**
+ * Close resources if applicable.
+ */
+ default void close() {
Review Comment:
Suggest adding this to `BlockDocIdIterator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
