lnbest0707-uber commented on code in PR #15234:
URL: https://github.com/apache/pinot/pull/15234#discussion_r2002157712
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java:
##########
@@ -1386,6 +1393,28 @@ public void testGetPartitionIds()
Assert.assertEquals(partitionIds.size(), 2);
}
+ @Test
+ public void testReduceSegmentSizeAndReset() {
+ // Set up a new table with 2 replicas, 5 instances, 4 partition
Review Comment:
done
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/BlockingSegmentCompletionFSM.java:
##########
@@ -181,6 +181,21 @@ public boolean isDone() {
BlockingSegmentCompletionFSMState.ABORTED);
}
+ /**
+ * The method is used to decide whether we should reduce segment size and
reset when server reports
+ * cannot build segment due to non-recoverable error.
+ * In most of cases, when such request is sent, the error should be
deterministic. However, due to possible data lost,
+ * replicas may not hold exact same data and some of them might be able to
build the segment.
+ * If the FSM _state indicates that one replica starts to commit.
Review Comment:
Change to comma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
